427034 - Crash/Error Reporter, Email field not disabled after submission

Status: RESOLVED FIXED

(Toolkit :: Crash Reporting, defect)

Description

[David Maza]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9b5) Gecko/2008032620 Firefox/3.0b5
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9b5) Gecko/2008032620 Firefox/3.0b5

After a crash in Mozilla Firefox, you are taken to the crash reporter. While you're submitting a crash you are able to click inside the email field and edit it despite it being grayed out.

Reproducible: Always

Steps to Reproduce:
1. Create a crash in Firefox
2. Input the details and click Restart Firefox, the crash will be submitted
3. You are able to click inside the email field and edit it while it's submitting, the field should be disabled/grayed out so that users are unable to change the email field while it's submitting. The description is disabled but the email field is not.

Comment 1

[David Maza]

http://s2.photobucket.com/albums/y17/quick_6066/?action=view&current=Bug.flv

Comment 2

[David Maza]

Anyone?

Comment 3

[timeless]

Attachment: this might work

Comment 4

[(not currently active) Ted Mielczarek]

Comment on attachment 315354 [details] [diff] [review]
this might work

This isn't going to work. The relevant bits are here:
http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/toolkit/crashreporter/client/crashreporter_win.cpp&rev=1.28#1108

Comment 5

[David Maza]

Any status on this issue?

Comment 6

[timeless]

Attachment: this is more likely to work

fwiw SetDlgItemDisabled is unused (which is very confusing)

Comment 7

[David Maza]

Is there a possibility for this to be fixed in RC2 or will it be delayed till 4.0?

Comment 8

[(not currently active) Ted Mielczarek]

It's not really that big of a deal. I doubt I'd bother trying to land it if we have an RC2. We can probably get it into a 3.0.x release.

Comment 9

[(not currently active) Ted Mielczarek]

Comment on attachment 319260 [details] [diff] [review]
this is more likely to work

That looks reasonable, although I haven't tested it. Maybe spin a try server build for testing? Should be ok to land this in mozilla-central, and then ask for approval1.9 to get it into 1.9.0.1.

Comment 10

[Carsten Book [:Tomcat]]

tryserver builds are here: https://build.mozilla.org/tryserver-builds/2008-05-15_07:[e-mail]-Bug427034-timeless/

Comment 11

[David Maza]

Any progress on this bug?

Comment 12

[(not currently active) Ted Mielczarek]

David: if you can test that build that Tomcat linked in the previous comment to ensure that the bug is fixed there, we can get this patch landed. All our work is done here in bugzilla, so if you don't see any activity, then nothing has happened in the bug.

Comment 13

[David Maza]

Anyway to force a crash in Vista? I've tried:

http://ted.mielczarek.org/code/mozilla/crashme.xpi

But it takes me the standard Microsoft Error Reporting Utility in Windows Vista.

Comment 14

[(not currently active) Ted Mielczarek]

Oh, since that's not an official build, you may need to edit application.ini in a text editor and add Enabled=1 below [Crash Reporter]

Comment 15

[David Maza]

I've already checked before I posted the comment and 'Enabled' has already been declared in application.ini and is set to 1.

Comment 16

[David Maza]

I finally managed to get it working after doing a registry tweak that disabled Error Reporting and DEP completely.

The tryserver build fixes the bug. Confirmed.

Comment 17

[(not currently active) Ted Mielczarek]

Thanks. We'll get this landed in mozilla-central when that opens for general checkins.

Comment 18

[David Maza]

Any chance of getting this into mozilla-central soon so that it can make Firefox 3.0.0?

Comment 19

[(not currently active) Ted Mielczarek]

This could land in mozilla-central at any time. It won't make Firefox 3.0, but it's possible that we could land it on the branch for 3.0.1 or another security release.

Comment 20

[(not currently active) Ted Mielczarek]

timeless: this can land in m-c. I can land it for you if you'd like.

Comment 21

[David Maza]

Any chance of getting it landed soon?

Comment 22

[timeless]

fixed in 16272:d272312ac39f