427060 - Get Error during XSLT transformation: Waiting for …

Status: RESOLVED FIXED

(Core :: XSLT, defect, P3)

Description

[George Olive]

User-Agent:       Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9b5) Gecko/2008032619 Firefox/3.0b5
Build Identifier: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9b5) Gecko/2008032619 Firefox/3.0b5

The supplied url fails in firefox 3 beta 3 through 5.  It works in firefox 2.

I built the page just for you guys, so if you have trouble getting to it let me know & I can just send you the files.

Reproducible: Always

Steps to Reproduce:
1.go to http://www.nottheworst.com/p/bookmarks.xml
2.
3.
Actual Results:  
Error during XSLT transformation: Waiting for …

Expected Results:  
a list of bookmarks with directories that open & close

It works in safari too.

Comment 1

[Ria Klaassen (not reading all bugmail)]

This was caused on 8 Sep 2006 probably by Bug 324092.

Comment 3

[Matthias Versen [:Matti]]

confirming based on dupe

Comment 4

[Jerome Yurow]

Just checking the status of this bug.  Looks like it is still unresolved.

Comment 5

[Jerome Yurow]

I am a relative newbie to this list.  What is the procedure for fixing bugs like this one?

Comment 6

[Matthias Versen [:Matti]]

Someone needs to analyze this issue, write a patch, get reviews and commit this to CVS. After that the bug status of this bug get changed from NEW to "fixed"

Comment 7

[Peter Van der Beken [:peterv]]

Attachment: v1

Comment 8

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Comment on attachment 331367 [details] [diff] [review]
v1

>diff --git a/content/xslt/src/xslt/txMozillaXMLOutput.cpp b/content/xslt/src/xslt/txMozillaXMLOutput.cpp
>--- a/content/xslt/src/xslt/txMozillaXMLOutput.cpp
>+++ b/content/xslt/src/xslt/txMozillaXMLOutput.cpp
>@@ -806,14 +806,15 @@ txMozillaXMLOutput::endHTMLElement(nsICo
>         nsAutoString value;
>         aElement->GetAttr(kNameSpaceID_None, txHTMLAtoms::target, value);
>         doc->SetBaseTarget(value);
> 
>-        aElement->GetAttr(kNameSpaceID_None, txHTMLAtoms::href, value);
>-        nsCOMPtr<nsIURI> baseURI;
>-        rv = NS_NewURI(getter_AddRefs(baseURI), value, nsnull);
>-        NS_ENSURE_SUCCESS(rv, rv);
>+        if (aElement->GetAttr(kNameSpaceID_None, txHTMLAtoms::href, value)) {
>+            nsCOMPtr<nsIURI> baseURI;
>+            rv = NS_NewURI(getter_AddRefs(baseURI), value, nsnull);
>+            NS_ENSURE_SUCCESS(rv, rv);
> 
>-        doc->SetBaseURI(baseURI); // The document checks if it is legal to set this base
>+            doc->SetBaseURI(baseURI); // The document checks if it is legal to set this base
>+        }

We don't really want to abort the transformation just because the attribute is specified but invalid, do we? Maybe just call SetBaseURI if a URI was successfully created, and ignore otherwise?

Comment 9

[Peter Van der Beken [:peterv]]

Attachment: v1.1