Cannot search with non-ascii characters (nsURLFormatter wrongly parses encoded uri)

VERIFIED FIXED in mozilla1.9

Status

()

Toolkit
Add-ons Manager
VERIFIED FIXED
10 years ago
10 years ago

People

(Reporter: kohei, Assigned: kohei)

Tracking

({intl})

unspecified
mozilla1.9
Points:
---
Bug Flags:
blocking1.9 +
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(3 attachments, 1 obsolete attachment)

(Assignee)

Comment 1

10 years ago
Created attachment 313862 [details] [diff] [review]
fix for 1.8 branch

Updated

10 years ago
Flags: blocking-firefox3?
(Assignee)

Updated

10 years ago
Attachment #313861 - Flags: review?(dtownsend)
(Assignee)

Updated

10 years ago
Attachment #313862 - Flags: review?(dtownsend)
Comment on attachment 313861 [details] [diff] [review]
fix

I am not a valid reviewer for this component. Maybe Gavin?

My only thought would be maybe the regex should only match sequences longer than 2 characters but that would break the ID case anyway.

Also it could do with a unit test I think.
Attachment #313861 - Flags: review?(dtownsend) → review?(gavin.sharp)

Updated

10 years ago
Attachment #313862 - Flags: review?(dtownsend)
(Assignee)

Comment 3

10 years ago
Here is a dump in the formatURL():

aMatch: %LOCALE%
aMatch: %LOCALE%
aMatch: %APP%
aMatch: %LOCALE%
aMatch: %APP%
aMatch: %BF% <- should not be cut off 
aMatch: %OS%
aMatch: %VERSION%
aMatch: %LOCALE%
aMatch: %BF% <- ditto.
aMatch: %OS%
aMatch: %VERSION%
(Assignee)

Updated

10 years ago
Blocks: 404024
Comment on attachment 313861 [details] [diff] [review]
fix

Please add a test for this to toolkit/components/urlformatter/tests/unit/test_urlformatter.js .
Attachment #313861 - Flags: review?(gavin.sharp) → review+
Assignee: nobody → kohei.yoshino.bugs
Flags: in-testsuite?

Updated

10 years ago
Status: NEW → ASSIGNED
Flags: blocking-firefox3? → blocking-firefox3+
Whiteboard: [has patch][has reviews]

Updated

10 years ago
Attachment #313861 - Flags: approval1.9?
Comment on attachment 313861 [details] [diff] [review]
fix

a=beltzner, please do file that test as well
Attachment #313861 - Flags: approval1.9? → approval1.9+
What is happening with this, why has it not landed yet?

Comment 7

10 years ago
Created attachment 317188 [details] [diff] [review]
unit test

Nakano-san, please check-in this and the patch for me.

Comment 8

10 years ago
Created attachment 317203 [details] [diff] [review]
unit test, fixed

Added a missing dot in encodedUrlRef.
Attachment #317188 - Attachment is obsolete: true

Updated

10 years ago
Whiteboard: [has patch][has reviews] → [has patch][has reviews][has approval]
checked-in the patch and the test.
Status: ASSIGNED → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
Flags: in-testsuite? → in-testsuite+
Whiteboard: [has patch][has reviews][has approval]
Target Milestone: --- → Firefox 3
(Assignee)

Comment 10

10 years ago
Verified.

Note that the search with non-ascii chars is still broken due to bug 415317.

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.4; en-US; rv:1.9pre) Gecko/2008042404 Minefield/3.0pre
Status: RESOLVED → VERIFIED
Product: Firefox → Toolkit
You need to log in before you can comment on or make changes to this bug.