How many characters in "hello" assert in Content Sink

RESOLVED INVALID

Status

()

Core
HTML: Parser
P3
normal
RESOLVED INVALID
18 years ago
16 years ago

People

(Reporter: Eric Pollmann, Assigned: Eric Pollmann)

Tracking

Trunk
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: fix in hand)

Attachments

(1 attachment)

(Assignee)

Description

18 years ago
I got an assert today in HTMLContentSink::AddDocTypeDecl

Basically, we strip characters from a string, then get the first char at the 
string without checking it's length to see if it's non-zero.  In some cases it 
may be zero length, and this is causing the assert.

Will attach a patch shortly.  Harish, can you review it?  Or if you would prefer 
to check it in, that's great too.  :)
(Assignee)

Comment 1

18 years ago
Created attachment 10208 [details] [diff] [review]
Proposed fix
(Assignee)

Updated

18 years ago
Status: NEW → ASSIGNED
Summary: How many characters in "hello" error in Content Sink → How many characters in "hello" assert in Content Sink
Whiteboard: fix in hand
Target Milestone: --- → M17
(Assignee)

Comment 2

18 years ago
I've heard of at least two other people who have fixes for this, one of which 
is better, so I'm going to close this one out (won't get lost because the 
asserts are too obvious!)
Status: ASSIGNED → RESOLVED
Last Resolved: 18 years ago
Resolution: --- → INVALID
(Assignee)

Comment 3

18 years ago
Asserts are fixed now.

Comment 4

17 years ago
updated qa contact.
QA Contact: janc → bsharma

Updated

16 years ago
QA Contact: bsharma → moied
You need to log in before you can comment on or make changes to this bug.