Closed Bug 427350 Opened 13 years ago Closed 12 years ago

Update data files to Unicode 5.1

Categories

(Core :: Internationalization, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla1.9.1

People

(Reporter: smontagu, Assigned: smontagu)

References

()

Details

(Keywords: fixed1.9.1)

Attachments

(1 file, 1 obsolete file)

Unicode 5.1 was released today. See http://wiki.mozilla.org/I18n:Updating_Unicode_version for instructions on updating data files.
Blocks: 438571
Attached patch Patch (obsolete) — Splinter Review
Attachment #328251 - Flags: review?(jdaggett)
The patch needs to be regenerated with the fix to bug 445626.
Depends on: 445626
Target Milestone: mozilla2.0 → mozilla1.9.1
Simon, do you have an updated version of this?
Attached patch Updated patchSplinter Review
Attachment #328251 - Attachment is obsolete: true
Attachment #347156 - Flags: review?
Attachment #328251 - Flags: review?(jdaggett)
Attachment #347156 - Flags: review? → review?(jdaggett)
Comment on attachment 347156 [details] [diff] [review]
Updated patch

Looks good.  Just curious, is bug 210501 really still an open issue?
Attachment #347156 - Flags: review?(jdaggett) → review+
(In reply to comment #5)
> (From update of attachment 347156 [details] [diff] [review])
> Just curious, is bug 210501 really still an open issue?

Yes. Fixing it would require either making the data tables significantly larger or rewriting nsICaseConversion to be stateful, and neither one seems justified when only one rare script that requires case conversions (the Deseret Alphabet) is encoded outside the BMP.
Comment on attachment 347156 [details] [diff] [review]
Updated patch

I'd like to get this in for 1.9.1 to maintain our policy of supporting the most recent Unicode version in our releases.
Attachment #347156 - Flags: approval1.9.1?
Pushed to trunk as http://hg.mozilla.org/mozilla-central/rev/b7d98dc8d246
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Flags: in-testsuite+
Comment on attachment 347156 [details] [diff] [review]
Updated patch

a191=beltzner
Attachment #347156 - Flags: approval1.9.1? → approval1.9.1+
You need to log in before you can comment on or make changes to this bug.