42740 - need nsHTMLEditor::GetFontColor()

Status: VERIFIED FIXED

(Core :: DOM: Editor, defect, P3)

Description

[Charles Manske]

We currently do not have methods equivalent to GetFontFace() to get the font
color or size. I suggest changing GetFontFace to:
GetFontProperty(nsString &aAttributeName, PRBool &aMixed, nsString &outValue)
so we can use "face", "size", and "color" as values for aAttributeName.

Comment 1

[Joe Francis]

accepting; m17

Comment 2

[Joe Francis]

i dont know what to report for size.  the #1 way people are going to change the 
size, i think, is from the toolbar.  that uses nested <big>s and <small>s, rather 
than a specific size.  

I think we should just not expose font size in the ui at all.  Just let folks 
make it bigger or smaller, without ever giving it a name.

Comment 3

[Joe Francis]

cc'ing folks for suggestions

Comment 4

[Charles Manske]

We don't need font size feedback, so let's postpose that pain. 
But we must return the font color: simply return the text value of the 'COLOR'
attribute. This is needed to show color feedback in the color picker.

Comment 5

[rubydoo123]

setting to m18 -- please update thebsummary to reflect the corrected issue -- 
need to set the correct priority too (please note that in the comment section)

Comment 6

[Joe Francis]

updating summary, took my best guess at priority

Comment 7

[Joe Francis]

Charlie, use nsIHTMLEditor::GetInlinePropertyWithAttrValue().  If you want I can 
put a wrapper for this in editorShell.  Assigning to charlie so he sees my 
comments.

Comment 8

[Charles Manske]

Ok, I can see how to do this now.

Comment 9

[Charles Manske]

checked in 8/22. We now have GetFontColorState() and GetBackgroundColorState()

Comment 10

[sujay]

marking verified.