427485 - gdk warnings during native theme drawing

Status: RESOLVED WORKSFORME

(Core :: Graphics, defect)

Description

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

This started with the latest cairo; this cairo has a pile of fixes to make various types of X visuals work with cairo (pesudocolor, etc.).  However, something seems to have changed in the surface creation, such that gdk prints warnings such as:


(Gecko:26391): Gdk-CRITICAL **: gdk_drawable_set_colormap: assertion `cmap == NULL || gdk_drawable_get_depth (drawable) == cmap->visual->depth' failed
(Gecko:26391): Gtk-CRITICAL **: gtk_paint_box: assertion `style->depth == gdk_drawable_get_depth (window)' failed
(Gecko:26391): Gtk-CRITICAL **: gtk_paint_arrow: assertion `style->depth == gdk_drawable_get_depth (window)' failed
(Gecko:26391): Gtk-CRITICAL **: gtk_paint_vline: assertion `style->depth == gdk_drawable_get_depth (window)' failed

for the first assertion, gdk_drawable_get_depth(gdkPixmap) at nsNativeThemeGTK.cpp:672 is 32, while colorMap->visual->depth is 24.  We're getting a 32-bit drawable, where we really want a 24-bit one; the other warnings are the same issue (style->depth is 24, and we have a 32 bit drawable).

I'm not sure where that 32-bit drawable is coming from.

Comment 1

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

So PushGroup with CAIRO_CONTENT_COLOR_ALPHA is now finding a 32-bpp X drawable.  The themes don't like that, so we need to take the slow path, but we don't.  I think.

Comment 2

[Benoit Jacob [:bjacob] (mostly away)]

What do we need to do about this?

Comment 3

[Gregory Pappas [:gregp]]

Unable to reproduce in current versions.