427510 - Drop nsISupportsArray usage from xpfe autocomplete code

Status: RESOLVED WONTFIX

(SeaMonkey :: Autocomplete, defect)

Description

[Mark Banner (:standard8)]

Attachment: Proposed fix (non-working)

nsISupportsArray is obsolete, currently the xpfe autocomplete code uses it. Fixing this will affect the mailnews address book and Camino as well.

Currently, the patch I've attached breaks the url bar on SeaMonkey, I haven't been able to work out why yet - no warnings/assertions are produced. The mailnews parts appear to work fine though.

Once I've got the main patch working, I'll be happy to try and put something together for Camino, though I haven't got a build machine for it at the moment.

Comment 1

[Stuart Morgan]

(In reply to comment #0)
> nsISupportsArray is obsolete, currently the xpfe autocomplete code uses it.

My understanding is that all of xpfe is obsolete; what's the advantage of changing the implementation of code we are supposed to stop using entirely anyway (especially since M2 won't have it at all)?

Comment 2

[Mark Banner (:standard8)]

(In reply to comment #1)
> (In reply to comment #0)
> > nsISupportsArray is obsolete, currently the xpfe autocomplete code uses it.
> 
> My understanding is that all of xpfe is obsolete; what's the advantage of
> changing the implementation of code we are supposed to stop using entirely
> anyway (especially since M2 won't have it at all)?

Sorry, Neil reminded me earlier today that basically we should resolve this properly by re-writing mailnews, bug 370306, (and Camino?) to use toolkit's version. Therefore resolving WONTFIX.