427703 - Add fields for party hosts

Status: RESOLVED WONTFIX

(Webtools Graveyard :: Party Tool, defect, P2)

Description

[Michael Morgan [:morgamic]]

- Full name
- Shipping Address
- T-shirt size
- email

We need to make sure we have these fields for party organizers.

Comment 2

[Alex Buchanan [:abuchanan]]

added shipping address and t-shirt size to user profile page.  
also added full name, email, shipping, t-shirt to the create party page asking the user to confirm that they are filled and accurate.

in r12896

Comment 3

[Alex Polvi]

hey. I'm a bit afraid that the "address" was poorly spec'd out. We need to make sure that they provide it to us in a pretty ridged format -- as address formats are different all around the world.

Here is an example of an intl form built on cake that we successfully used: 

https://bugzilla.mozilla.org/show_bug.cgi?id=411794#c2

Comment 4

[Alex Buchanan [:abuchanan]]

(In reply to comment #3)
> hey. I'm a bit afraid that the "address" was poorly spec'd out. We need to make
> sure that they provide it to us in a pretty ridged format -- as address formats
> are different all around the world.
> 
> Here is an example of an intl form built on cake that we successfully used: 
> 
> https://bugzilla.mozilla.org/show_bug.cgi?id=411794#c2
> 
excellent, thanks polvi, that was my next question

also, do we have standard list of shirt sizes?  in bug 411794 i see...
- T-Shirt Size* - Men-S,M,L,XL,2XL, Women-S,M,L,XL

Comment 5

[Alex Polvi]

(In reply to comment #4)
> also, do we have standard list of shirt sizes?  in bug 411794 i see...
> - T-Shirt Size* - Men-S,M,L,XL,2XL, Women-S,M,L,XL

Yes, that's it. Let me double check about womens sizes, but run with that for now.

Comment 6

[Alex Buchanan [:abuchanan]]

Attachment: Add new fields for international address, phone

note: this changes the DB schema, so remember to update the DB when committed

Comment 7

[Ryan Flint [:rflint] (ping via IRC for reviews)]

Comment on attachment 321410 [details] [diff] [review]
Add new fields for international address, phone

User.name is shown publicly and this form is going to force anyone who's opted out of that by using a nickname to change it. Please add a field specifically for the full name and switch over to that before checking this in.

Comment 8

[Alex Buchanan [:abuchanan]]

committed in r13333.  stage needs a DB update

Comment 9

[Alex Buchanan [:abuchanan]]

also, needs validation in Events_controller::add() to make User fields required

Comment 10

[Alex Buchanan [:abuchanan]]

Attachment: Add check for required user fields

Comment 11

[Ryan Flint [:rflint] (ping via IRC for reviews)]

hmm, do we really want to make these fields a hard requirement? I just have a feeling requiring full shipping info to create an event is going to turn a lot of people off. Maybe have something like a 'if my event qualifies, send me a t-shirt' checkbox that shows/hides that part of the form and runs validation on these fields when set.

Code-wise looks ok except someone can tack a [User][role] input on the form to elevate their privileges. We should probably just add a beforeSave check in the user model to enforce whatever's set in the database since we don't have any UI to flip that bit. Giving User::save a list of fields you'll be changing is also an option to prevent that and might be a good idea anyway.

Comment 12

[Alex Polvi]

Ryan, good call. Lets not make the address shipping and required -- and add the like:

"If my event qualifies, send me a party pack"

It is fine if that just enables/disables the fields in the form.

Comment 13

[Alex Buchanan [:abuchanan]]

Attachment: Make party pack optional

ok, should all work optionally now,  Ryan will you double check, make sure nothing is broken?

Polvi, how do you describe a party pack?  On the form there is a party pack description string.  I just used this as a placeholder...

"A party pack is a box full of goodies that Mozilla can send to help make your party great!"  

haha, maybe you have a more fitting description?

Comment 14

[Ryan Flint [:rflint] (ping via IRC for reviews)]

Comment on attachment 321976 [details] [diff] [review]
Make party pack optional

woo.

Comment 15

[Alex Buchanan [:abuchanan]]

patch committed, updated strings too
r13471

Comment 16

[Alex Polvi]

shipping address needs to appear when editing if previously filled in.

Comment 17

[Alex Buchanan [:abuchanan]]

broken because the stage DB schema hasn't been updated yet.  will get that updated soon.