427711 - Can't rename a local folder to exactly the same name

Status: VERIFIED FIXED

(MailNews Core :: Backend, defect)

Description

[Phil Ringnalda (:philor)]

Attachment: Fix v.1

STR:
1. Right-click a local folder, select Rename
2. Without changing the name, click OK

If you're on Linux or Windows, you'll get an alert telling you that a folder with that name exists (duh); if you're on Mac, since you already have a modal sheet open, you'll get nothing until you cancel, at which point you'll get an even more senseless alert, telling you that you have to choose something different in the sheet that's already gone.

I don't even pretend to understand nsLocalMailFolder.cpp, but this seems to work, and seems reasonable enough to me.

Comment 1

[David :Bienvenu]

Comment on attachment 314282 [details] [diff] [review]
Fix v.1

seems safe enough - I wonder if we should return an error, though, or maybe just assert. Also, ideally, the front end code wouldn't even call Rename if the name didn't change. But I don't think this can hurt anything...

Comment 2

[Phil Ringnalda (:philor)]

I thought about an error for a while, but firstly, I don't trust people not to propagate it up to the user, who should never, ever see word one about it, and secondly, I didn't manage to imagine the programmer who needs to know that he unknowingly tried to rename a folder to the same name, so I decided that when he finds out he doesn't get one, I'll let *him* decide what error he wants to get back. The front end I've got to touch anyway, so I'll see about giving it some minimal smarts.

mailnews/local/src/nsLocalMailFolder.cpp 1.575

Comment 3

[Serge Gautherie (:sgautherie)]

Between
[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9pre) Gecko/2008041001 SeaMonkey/2.0a1pre] (nightly) (W2Ksp4)
and
[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9pre) Gecko/2008041102 SeaMonkey/2.0a1pre] (nightly) (W2Ksp4)

V.Fixed