427744 - List Plugin File Version Number under about:plugins

Status: RESOLVED FIXED

(Core Graveyard :: Plug-ins, defect)

Description

[Carsten Book [:Tomcat]]

Currently we have the Problem when we think about Plugin blocklisting, that we don't have in most cases the File Version Number of the Plugins.

On Windows currently the only way is to use the Windows Explorer -> Properties -> File Version, to see the File Version of a Plugin DLL

Having a File Version Information in about:plugins would make the debugging and blocklist work easier.

Bug 427743 is about exposing the File Version Number and this Bug is about showing this information in about:plugins

Comment 1

[Damon Sicore (:damons)]

Again, wouldn't hold the release for this.  But, good idea, Carsten!  :)

Comment 2

[Dave Townsend [:mossop]]

Can't do this without another interface change on top of bug 427743. We'd need to alter nsIDOMPlugin which is exposed to the web so I suspect we really don't want this for 1.9.1.

Comment 3

[Dave Townsend [:mossop]]

Attachment: patch rev 1

This is a patch that does it.

Comment 4

[Josh Aas]

Dave, can we take this patch on trunk (1.9.2) now?

Comment 5

[Dave Townsend [:mossop]]

(In reply to comment #4)
> Dave, can we take this patch on trunk (1.9.2) now?

I don't see why not, I'll find some time to check it still applies and works ok. Maybe throw in a test too.

Comment 6

[Dave Townsend [:mossop]]

Attachment: patch rev 2

Mostly unbitrotting, added a testcase too.

Not positive of the right reviewers, let me know if there is a better choice.

Comment 7

[Josh Aas]

Comment on attachment 373878 [details] [diff] [review]
patch rev 2

I don't know much about the web compat or security implications of exposing that via the DOM but aside from that this looks good. I'm sure jst can expertly weigh in on the DOM exposure.

Comment 8

[Johnny Stenback (:jst)]

Oh, and I meant to say that I don't see a problem exposing this information to the web, there's nothing new here really, the description and the name is already exposed, and either or both of those often contain the version number anyways already.

Comment 9

[Dave Townsend [:mossop]]

Landed: http://hg.mozilla.org/mozilla-central/rev/bc97423f1193

Comment 10

[Steffen Wilberg]

Adding dev-doc-needed for https://developer.mozilla.org/en/navigator.plugins, please also fix the dead xulplanet links there.

Comment 11

[Eric Shepherd [:sheppy]]

The document here has been updated:

https://developer.mozilla.org/en/DOM/window.navigator.plugins

In addition, I added the following two articles to the DOM Reference, although the subpages for each property and method have not yet been written. But this is still a vast improvement over broken links to XULPlanet.

https://developer.mozilla.org/en/DOM/PluginArray
https://developer.mozilla.org/en/DOM/Plugin