List Plugin File Version Number under about:plugins

RESOLVED FIXED in mozilla1.9.2a1

Status

()

defect
RESOLVED FIXED
11 years ago
9 years ago

People

(Reporter: cbook, Assigned: mossop)

Tracking

({dev-doc-complete})

Trunk
mozilla1.9.2a1
Points:
---
Dependency tree / graph
Bug Flags:
blocking1.9 -
wanted1.9.0.x +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Currently we have the Problem when we think about Plugin blocklisting, that we don't have in most cases the File Version Number of the Plugins.

On Windows currently the only way is to use the Windows Explorer -> Properties -> File Version, to see the File Version of a Plugin DLL

Having a File Version Information in about:plugins would make the debugging and blocklist work easier.

Bug 427743 is about exposing the File Version Number and this Bug is about showing this information in about:plugins
Flags: wanted1.9.0.x?
Flags: blocking1.9?
No longer blocks: 427743
Depends on: 427743
Again, wouldn't hold the release for this.  But, good idea, Carsten!  :)
Flags: wanted1.9.0.x?
Flags: wanted1.9.0.x+
Flags: blocking1.9?
Flags: blocking1.9-
Can't do this without another interface change on top of bug 427743. We'd need to alter nsIDOMPlugin which is exposed to the web so I suspect we really don't want this for 1.9.1.
Posted patch patch rev 1 (obsolete) — Splinter Review
This is a patch that does it.
Flags: wanted1.9.2?
Dave, can we take this patch on trunk (1.9.2) now?
(In reply to comment #4)
> Dave, can we take this patch on trunk (1.9.2) now?

I don't see why not, I'll find some time to check it still applies and works ok. Maybe throw in a test too.
Posted patch patch rev 2Splinter Review
Mostly unbitrotting, added a testcase too.

Not positive of the right reviewers, let me know if there is a better choice.
Assignee: nobody → dtownsend
Attachment #329655 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #373878 - Flags: superreview?(jst)
Attachment #373878 - Flags: review?(joshmoz)
Comment on attachment 373878 [details] [diff] [review]
patch rev 2

I don't know much about the web compat or security implications of exposing that via the DOM but aside from that this looks good. I'm sure jst can expertly weigh in on the DOM exposure.
Attachment #373878 - Flags: review?(joshmoz) → review+
Attachment #373878 - Flags: superreview?(jst) → superreview+
Oh, and I meant to say that I don't see a problem exposing this information to the web, there's nothing new here really, the description and the name is already exposed, and either or both of those often contain the version number anyways already.
Landed: http://hg.mozilla.org/mozilla-central/rev/bc97423f1193
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.2a1
Flags: wanted1.9.2?
Adding dev-doc-needed for https://developer.mozilla.org/en/navigator.plugins, please also fix the dead xulplanet links there.
Keywords: dev-doc-needed
The document here has been updated:

https://developer.mozilla.org/en/DOM/window.navigator.plugins

In addition, I added the following two articles to the DOM Reference, although the subpages for each property and method have not yet been written. But this is still a vast improvement over broken links to XULPlanet.

https://developer.mozilla.org/en/DOM/PluginArray
https://developer.mozilla.org/en/DOM/Plugin
You need to log in before you can comment on or make changes to this bug.