427845 - reftests/text-decoration/underline-block-propagation-*.html are buggy

Status: RESOLVED FIXED

(Core :: Layout: Block and Inline, defect)

Description

[Zack Weinberg (:zwol)]

User-Agent:       Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10_5_2; en-us) AppleWebKit/525.13 (KHTML, like Gecko) Version/3.1 Safari/525.13
Build Identifier: 

There are three problems with the underline-block-propagation-*.html reftests:

1) Typos, "inline:block" where "inline-block" is meant.
2) Fixing (1) reveals that the reference rendering for inline-block is wrong.
3) There are no tests for inline-table.

I shall attach a candidate patch for all of the above.  The major problem with it is that I'm not sure whether the reference renderings for inline-table are correct yet.

Reproducible: Always

Comment 1

[Zack Weinberg (:zwol)]

Blocks bugs 403524 and 403526, because fixing those bugs will not fix the associated reftests as long as the tests themselves are incorrect.

Comment 2

[Zack Weinberg (:zwol)]

Attachment: patch candidate #1

I would claim the bug but I don't have that privilege.

I should mention that the impact of this patch is negligible - the reftests in question are known failures now, and they will still be known failures after this patch goes in.  Thus it should be safe to commit despite the imminent freeze, if the inline-table reference renderings are confirmed to be correct.

Comment 3

[Zack Weinberg (:zwol)]

yay, I can assign the bug to myself now.

Comment 4

[Zack Weinberg (:zwol)]

Attachment: patch candidate #2

after offline discussion with dbaron, this revised patch is believed to be correct for all cases.

Cross-browser compat notes: Opera 9.27 (Mac) renders both -quirks and -standards variants identically to their references (i.e. displays the behavior that is believed to be correct).  The only difference between its quirks rendering and its standards rendering is that in standards mode, the float is rendered to the left of the bare line of text above it in the HTML, whereas in quirks mode the float is rendered below that text.

Safari 3.1 (also Mac) does not render either -quirks or -standards variants identically to their reference renderings.  It does not implement display:inline-table the same way either Opera or Gecko does;   the span in question is placed entirely above the surrounding line of text, just as for display:inline-block, but with a few pixels of whitespace between the baseline of the bottommost line of text and the baseline of the surrounding text (unlike inline-block, where the baselines are aligned).  It does not underline anything inside the inline-block or inline-table spans, but it does draw a line underneath the span itself.  The float is to the left of the preceding-in-HTML text, and its text is underlined; the position:absolute div's text is also underlined.  There is no difference between its quirks rendering and its standards rendering.

I believe Safari to be buggy, and Opera to be correct.

Comment 5

[Zack Weinberg (:zwol)]

Clarification: I believe opera's behavior with respect to underlining to be correct.  I have no opinion on the float behavior and its observed difference between quirks and standards mode.

Comment 6

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Comment on attachment 314422 [details] [diff] [review]
patch candidate #2

r=dbaron.

No reason this can't just land now, since it's test-only (and the tests are currently failing in both cases).

Comment 7

[Reed Loden [:reed]]

Checking in layout/reftests/text-decoration/underline-block-propagation-quirks-ref.html;
/cvsroot/mozilla/layout/reftests/text-decoration/underline-block-propagation-quirks-ref.html,v  <--  underline-block-propagation-quirks-ref.html
new revision: 1.2; previous revision: 1.1
done
Checking in layout/reftests/text-decoration/underline-block-propagation-quirks.html;
/cvsroot/mozilla/layout/reftests/text-decoration/underline-block-propagation-quirks.html,v  <--  underline-block-propagation-quirks.html
new revision: 1.2; previous revision: 1.1
done
Checking in layout/reftests/text-decoration/underline-block-propagation-standards-ref.html;
/cvsroot/mozilla/layout/reftests/text-decoration/underline-block-propagation-standards-ref.html,v  <--  underline-block-propagation-standards-ref.html
new revision: 1.2; previous revision: 1.1
done
Checking in layout/reftests/text-decoration/underline-block-propagation-standards.html;
/cvsroot/mozilla/layout/reftests/text-decoration/underline-block-propagation-standards.html,v  <--  underline-block-propagation-standards.html
new revision: 1.2; previous revision: 1.1
done