Closed Bug 427874 Opened 12 years ago Closed 12 years ago

now(), local-dateTime() have issues on Mac

Categories

(Core Graveyard :: XForms, defect)

1.8 Branch
x86
macOS
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: aaronr, Assigned: aaronr)

Details

(Keywords: fixed1.8.1.17)

Attachments

(3 files)

Found by a user and reported on the Mozilla xforms NG.  It looks like some junk characters are getting inserted into the xpath values that we return for now() and local-dateTime().  Only seems to happen on Mac and then only on FF2.

Debugged by Javier.  Looks like it is because of an issue with AssignLiteral when we are passing in a char array as a parameter instead of a const char *.

I'm going to fix this by removing any calls to AssignLiteral or AppendLiteral that don't take hardcoded strings to make sure that we don't miss anything.  I'll replace them with Assign(NS_ConvertASCIItoUTF16(xxx)) and Append(NS_ConvertASCIItoUTF16(xxx)).  I'm making this change on the trunk, too, so that we keep our code as common as possible between trunk and branch.
Attached patch patch for trunkSplinter Review
Attachment #314428 - Flags: review?(Olli.Pettay)
Attachment #314428 - Flags: review?(doronr)
Comment on attachment 314428 [details] [diff] [review]
patch for trunk

Looks ok, not a string guru though.
Attachment #314428 - Flags: review?(doronr) → review+
seem to have the same problem on Ubuntu Linux, not just Macs.
0.8.5 release on FF 2.0.0.13  

see
http://groups.google.com/group/mozilla.dev.tech.xforms/browse_thread/thread/0544fa191d3b6422#
Attachment #314428 - Flags: review?(Olli.Pettay) → review+
checked into trunk
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Whiteboard: xf-to-branch
checked into 1.8 branch
Keywords: fixed1.8.1.17
Whiteboard: xf-to-branch
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.