427916 - YUI libraries need pruning before launch

Status: RESOLVED FIXED

(www.mozilla.org :: General, defect)

Description

[Wil Clouser [:clouserw]]

Couple of things with the YUI libraries on the FF3 branch:

1) There is a copy of YUI 2.5.0 in /yui/ and a copy of YUI 2.3.0 in /js/yui/.  The 2.3.0 library is in the correct place - if we're using 2.5 we should replace the old one and remove the version that is on the root.

2) If we decide to use the 2.5.0 version, we need to prune the files in it.  Right now there are README's, compressed, and uncompressed versions of every portion of the YUI library.  We should only have the compressed versions of what we're actually using.

I'm assigning this to sgarrity because he'll have the best idea of what needs to stay or go.  I'm happy to help move this stuff around once we figure out what needs to happen.

Comment 1

[Michael Morgan [:morgamic]]

CC-ing Ryan in case he has any input that could help.

Comment 2

[Steven Garrity [:sgarrity]]

Wil, I had moved the YUI files from /js/ to the root because they contain both CSS and JS files. Is there any harm to keeping the entire file set in place?

Comment 3

[Ryan Doherty (:rdoherty)]

I can take a look at it, I need more info on where these libraries are, etc.

Comment 4

[Wil Clouser [:clouserw]]

(In reply to comment #2)
> Wil, I had moved the YUI files from /js/ to the root because they contain both
> CSS and JS files. 

If you want to go down that road, it should be in /includes/.  Let's keep the root as clean as possible.

> Is there any harm to keeping the entire file set in place?

It's messy and unnecesary.  I don't mind READMEs for the portions we're using but having compressed and uncompressed versions of the same thing is pointless.  YUI is split up into 44 chunks just so you can use only what you need.  Having 13MB of files in SVN that we aren't using doesn't make sense.

Comment 5

[Steven Garrity [:sgarrity]]

No pruning done yet, but I've updated to YUI 2.5.1 and move the files into the /includes/ dir in r12095.

Comment 6

[Mike Beltzner [:beltzner, not reading bugmail]]

Not sure why this needs to block release of Firefox 3, please renom with justification if you want it to block.

Comment 7

[Steven Garrity [:sgarrity]]

Cleaning up / minifying YUI stuff might be part of general performance improvements.

Comment 8

[Jesse Ruderman]

Sounds more like "blocking" than "duplicate".

Comment 9

[Steven Garrity [:sgarrity]]

I may have muddied the waters in my comment #7, but I think this bug really covers having all of the YUI files on the server, not any client-side optimizations. Should remain closed. If we can simplify/improve the YUI JS that actually gets included on pages, lets make that a new bug.