428001 - Whole UI flashes when autocomplete shows results after not showing results

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect)

Description

[Stephen Donner [:stephend] Not actively reading bugmail]

Summary: Flashing during autocomplete in a new tab

Marcia and I have been seeing this on the trunk lately--for me, it's been happening the past 3-5 days or so :-(

Steps to Reproduce (just one way):

1. Make sure "new" has 3 or so autocomplete entries (I have 3 news.com entries)
2. Command+T
3. Type "www.news"
4. Let it autocomplete and then backspace

Actual Results:

I see some sort of reflow/flashing, which is so quick it's hard to tell where it occurs, but it definitely feels like we flash in the location bar itself

Expected Results:

No flashing

Comment 1

[Ed Lee :Mardak]

I'm not sure if this is the same thing, but I couldn't reproduce with those steps, but if you search for "/" then "$$$" (something that results in no results), backspace to back to "/" and the *whole* chrome flashes when it is about to show the list.

Comment 2

[Ed Lee :Mardak]

Seems to be mac only.. or at least I don't see flashing on windows xp over remote desktop.

Everything in the toolbar, status bar (but not title bar) flashes white on OS X.

Comment 3

[Stephen Donner [:stephend] Not actively reading bugmail]

Yeah, Mac-only, and my steps aren't really fool-proof in reproducing the problem; your steps in comment 1 do it for me 100%.

Comment 4

[Ed Lee :Mardak]

Potentially a Proto issue?

http://forums.mozillazine.org/viewtopic.php?p=3331792#3331792

Comment 5

[Ed Lee :Mardak]

Could you find a regression range now that we have a 100% working STR?

Comment 6

[Marcia Knous [:marcia]]

There are also a few comments in Bug 427935 which address this issue.

Comment 7

[Mike Beltzner [:beltzner, not reading bugmail]]

I'd mark this as a dupe, except that comment 0 says it's been happening longer. Should we just get 427935 in and deal with this seperately?

Comment 8

[Stephen Donner [:stephend] Not actively reading bugmail]

afaict, this has nothing to do with bug 427395, given that I can reproduce with Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.4; en-US; rv:1.9pre) Gecko/2008040404 Minefield/3.0pre, which was not even filed until the 8th.

I'm hunting for a better regression range...

Comment 9

[Stephen Donner [:stephend] Not actively reading bugmail]

(Bug 427935, even, but you knew that.)

Comment 10

[Stephen Donner [:stephend] Not actively reading bugmail]

Regression range is between 2008-04-02 04 (works) and 2008-04-03 04 (fails):

http://tinyurl.com/5s54g6

Comment 11

[Stephen Donner [:stephend] Not actively reading bugmail]

Edward: looking like either bug 415190 or bug 424868's changes, which were both in 1.134 of autocomplete.xml?

Comment 12

[Ed Lee :Mardak]

Attachment: v1

Strange stuff happens when we set height to 0 it seems... so don't do it. And also fix that other bug about not calculating height for each appendresult.

Comment 13

[Ed Lee :Mardak]

Oh, forgot to mention that it makes the whole list appear instead of showing 5 items then adding 1 item. That also makes the list draw in 2 updates instead of 3. (6 + 6 vs 5 + 5 + 2).

Comment 14

[Ed Lee :Mardak]

Do you see the problem here?

https://build.mozilla.org/tryserver-builds/2008-04-09_23:[e-mail]/

Comment 15

[Stephen Donner [:stephend] Not actively reading bugmail]

(In reply to comment #14)
> Do you see the problem here?
> 
> https://build.mozilla.org/tryserver-builds/2008-04-09_23:[e-mail]/

Your tryserver build fixes it for me, thanks!

Comment 16

[Ed Lee :Mardak]

Comment on attachment 314765 [details] [diff] [review]
v1

a1.9? For a kinda annoying bug and UI badness.

litmus test: see comment 1

Comment 17

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 314765 [details] [diff] [review]
v1

a1.9=beltzner

Comment 18

[Ed Lee :Mardak]

Checking in toolkit/content/widgets/autocomplete.xml;
/cvsroot/mozilla/toolkit/content/widgets/autocomplete.xml,v  <--  autocomplete.xml
new revision: 1.136; previous revision: 1.135
done

Comment 19

[Stephen Donner [:stephend] Not actively reading bugmail]

in-litmus+:

https://litmus.mozilla.org/show_test.cgi?id=5259

I actually verified this using the 4-12 build on OS X 10.4, but forgot to come mark it here.