428008 - Adaptive learning matches on removed/deleted tags. (adaptive matching overrides tags).

Status: RESOLVED INVALID

(Firefox :: Address Bar, defect)

Description

[[:Aleksej]]

Mozilla/5.0 (X11; U; Linux i686; eo; rv:1.9pre) Gecko/2008040904 Minefield/3.0pre

Adaptive learning remembers and matches the pages that do not match the strings anymore. This makes temporary tags useless after some time of a profile usage.

Steps to Reproduce:
1. Tag some (preferably 6-10 or more) pages with a tag not present in the URLs or titles.
Visit those pages many times, so they have a high frecency. All or some of them should have the highest frecency among all of the places throughout the whole test.
2. Tag some more pages with that tag. The sum should be (or you can just imagine that it is) higher than the number of entries in the autocomplete dropdown list.
3. Remove the tag from some or all of the places from step 1. The untagged places should have high frecency, and there should be enough of them for step 2.
4. Enter the tag into the Location bar to get suggestions.

Actual results:
Few or none of the pages that are still tagged are displayed; the list is full of adaptive results that had been tagged before, but are not anymore, because of frecency.

Expected results:
All (or however many can fit) of the pages currently tagged with the tag should be at the top of the suggestion list.
Pages that do not match on anything but the adaptive memory should be underneath or not appear in the list at all.

Comment 1

[Ed Lee :Mardak]

This would be fixed by the patch in bug 395161.

Comment 2

[Ed Lee :Mardak]

Do you see the issue with this build?

https://build.mozilla.org/tryserver-builds/2008-04-05_02:[e-mail]-urlbar/

Comment 3

[[:Aleksej]]

(In reply to comment #1)
> This would be fixed by the patch in bug 395161.

Yes, just filed this one to document the issue and have bug 395161 fixed sooner.

On its own, the behavior in this bug is sometimes useful for unstarred places matching from history, e.g. when a page title changes without the user knowing, and the original title is not stored in a bookmark.

Comment 4

[[:Aleksej]]

(In reply to comment #2)
> Do you see the issue with this build?
> 
> https://build.mozilla.org/tryserver-builds/2008-04-05_02:[e-mail]-urlbar/

No, I don’t see the issue with that build. More power to that patch. :)

OTOH, will it remove the useful part mentioned in comment #3, too?

Comment 5

[Mike Beltzner [:beltzner, not reading bugmail]]

This doesn't block, and I think it's wontfix. Adaptive learning is doing the absolute right thing here, which is using entered patterns to predict desired results.

This entire bug feels like a vote for bug 395161, and in my opinion, is INVALID.

(note: I love bug 395161, too - hell, I asked for it)

Comment 6

[[:Aleksej]]

Anyway, that patch seems to fix this very bug, and not just 395161. The entries from which the tag is removed are not matched at all.