428097 - Bookmarks Toolbar menu item in Bookmarks Menu doesn't have a menu icon

Status: VERIFIED FIXED

(Firefox :: Theme, defect, P2)

Description

[Andrés Delfino]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9pre) Gecko/2008040907 Minefield/3.0pre
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9pre) Gecko/2008040907 Minefield/3.0pre

Bookmarks Toolbar menu item in Bookmarks Menu doesn't have a menu icon.

Reproducible: Always

Steps to Reproduce:
1. Open the Bookmarks menu.
2. See the Bookmarks Toolbar menu item.
Actual Results:  
Bookmarks Toolbar has no icon.

Expected Results:  
Bookmarks Toolbar should have an icon.

Comment 1

[Andrés Delfino]

Attachment: Screenshot.

Comment 2

[Andrés Delfino]

Nominating as blocking since all this work around Library should be as consistent as possible, since it's new stuff that the user will experiment with.

Comment 3

[Marcia Knous [:marcia]]

I see this on Win Vista as well, confirming using  Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9pre) Gecko/2008040907 Minefield/3.0pre.

Comment 4

[Mike Beltzner [:beltzner, not reading bugmail]]

Blocking because this is a regression - we used to show an icon here, what's going on?

Marco, could this be related to your checkin from bug 421483?

Comment 5

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

doubt it, i simply created some bookmark and moved a separator...

Comment 6

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

Attachment: patch

needs region

Comment 7

[Dietrich Ayala (:dietrich)]

This is WFM on Mac. Isn't auto the default value for -moz-image-region? Seems like you shouldn't need to specify it at all...

Comment 8

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

on win the style def is at the end of the file so probably region is defined in a previous styling (probably the generic container). will check later probably could be solved moving up the style in the css

Comment 9

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

Attachment: patch

so, after a check, the fix is only needed on winstripe since is the only theme that uses moz-region for bookmark-item, and being toolbar folder a bookmark-item[container] its region needs to be overloaded with auto.

Comment 10

[Dietrich Ayala (:dietrich)]

Comment on attachment 314979 [details] [diff] [review]
patch

r=me, thanks!

Comment 11

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 314979 [details] [diff] [review]
patch

a1.9=beltzner

Comment 12

[Dietrich Ayala (:dietrich)]

Checking in browser/themes/winstripe/browser/browser.css;
/cvsroot/mozilla/browser/themes/winstripe/browser/browser.css,v  <--  browser.css
new revision: 1.197; previous revision: 1.196
done