428250 - clicking in blank space in file column of directory listing activates links

Status: RESOLVED FIXED

(Core :: Networking, defect)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Since the new directory listings (bug 294800) landed, I've often accidentally activated links by clicking in the blank space, which I often do to focus the content area (so I can scroll with the keys) or to clear the selection.  I think either (a) areas that don't look like links shouldn't be or (b) the style should make things much clearer which things are links.

Solution (a) could be done, I believe, by simply removing these three lines:
http://bonsai.mozilla.org/cvsblame.cgi?file=/mozilla/netwerk/streamconv/converters/nsIndexedToHTML.cpp&rev=1.90&root=/cvsroot&mark=333-335#333

Steps to reproduce:
 1. load ftp://ftp.mozilla.org/pub/
 2. click in the blank space to the right of the file names ("addons", "artwork", "bouncer", etc.) but to the left of the size column

Actual results: end up following the file or directory horizontally adjacent to the blank space I click on

Expected results: focus content area and clear selection

Additional comments:  I'd also note that there's a tiny bit of hover feedback to circle the entire item, including the size and last-modified.  This doesn't make it look like a link to me -- and even if it did, only *part* of the area that shows the hover feedback is a link.

Comment 1

[Dão Gottwald [:dao]]

(In reply to comment #0)
> Solution (a) could be done, I believe, by simply removing these three lines:
> http://bonsai.mozilla.org/cvsblame.cgi?file=/mozilla/netwerk/streamconv/converters/nsIndexedToHTML.cpp&rev=1.90&root=/cvsroot&mark=333-335#333

Removing it would also remove the left padding from the second line of long file names, but inline-block should work.

> Additional comments:  I'd also note that there's a tiny bit of hover feedback
> to circle the entire item, including the size and last-modified.  This doesn't
> make it look like a link to me -- and even if it did, only *part* of the area
> that shows the hover feedback is a link.

see bug 392802 comment 13 et seq.

Comment 2

[Dão Gottwald [:dao]]

Attachment: patch

This also fixes the underlining for the selected table header to exclude the sorting arrow. Not sure when the original styling broke.

Comment 3

[Dão Gottwald [:dao]]

display:block was added in bug 393681 without ui review.

Comment 4

[Asaf Romano (gone)]

Comment on attachment 315283 [details] [diff] [review]
patch

r=mano on the changes to toolkit/themes.

Comment 5

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 315283 [details] [diff] [review]
patch

a1.9=beltzner

Comment 6

[:Gavin Sharp [email: [e-mail]]]

mozilla/netwerk/streamconv/converters/nsIndexedToHTML.cpp 	1.94
mozilla/toolkit/themes/pinstripe/global/dirListing/dirListing.css 	1.6
mozilla/toolkit/themes/winstripe/global/dirListing/dirListing.css 	1.8