428341 - wrong error message displayed when installing an extension that isn't compatible with the app

Status: VERIFIED FIXED

(Toolkit :: Add-ons Manager, defect)

Description

[:Gavin Sharp [email: [e-mail]]]

I tried installing DOMi from AMO, using a new profile and today's nightly, on Windows.

After the XPI is downloaded, I get a "unexpected installation error" dialog, with error -203 that says to check the error console. The console says:

Error: installData.currentApp is null
Source File: file:///C:/Users/Gavin/Desktop/firefox/components/nsExtensionManager.js
Line: 4575

Comment 1

[Dave Townsend [:mossop]]

This bug will display an unexpected installation error message when you attempt to install a new extension that is not compatible with the application (i.e. trying to install a Thunderbird extension into Firefox).

The fix is pretty trivial though.

Comment 2

[Dave Townsend [:mossop]]

Attachment: patch rev 1

This adds unit tests to ensure that installItemFromFile runs to completion for a large set of invalid xpi cases. The only case that isn't really checked is the blocklist case since that will attempt to open a window on failure.

This catches this failure case and one other failure. When there is no install.rdf in the xpi an exception was being thrown trying to delete the missing extracted file. The existance of the file is checked before attempting to parse the manifest and then delete it.

Comment 3

[Dave Townsend [:mossop]]

Comment on attachment 314968 [details] [diff] [review]
patch rev 1

This patch makes some trivial changes to avoid exceptions occurring when installing xpi's that are not compatible with the application in a couple of ways. The risk of regression from this is very low while it ensures that users see a more appropriate error message. It also includes a set of testcases for installing incompatible xpis.

Comment 4

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 314968 [details] [diff] [review]
patch rev 1

a1.9=beltzner

Comment 5

[Dave Townsend [:mossop]]

Checking in src/nsExtensionManager.js.in;
/cvsroot/mozilla/toolkit/mozapps/extensions/src/nsExtensionManager.js.in,v  <--  nsExtensionManager.js.in
new revision: 1.287; previous revision: 1.286
done
RCS file: /cvsroot/mozilla/toolkit/mozapps/extensions/test/unit/test_bug428341.js,v
done
Checking in test/unit/test_bug428341.js;
/cvsroot/mozilla/toolkit/mozapps/extensions/test/unit/test_bug428341.js,v  <--  test_bug428341.js
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/toolkit/mozapps/extensions/test/unit/addons/test_bug428341_1/README,v
done
Checking in test/unit/addons/test_bug428341_1/README;
/cvsroot/mozilla/toolkit/mozapps/extensions/test/unit/addons/test_bug428341_1/README,v  <--  README
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/toolkit/mozapps/extensions/test/unit/addons/test_bug428341_2/install.rdf,v
done
Checking in test/unit/addons/test_bug428341_2/install.rdf;
/cvsroot/mozilla/toolkit/mozapps/extensions/test/unit/addons/test_bug428341_2/install.rdf,v  <--  install.rdf
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/toolkit/mozapps/extensions/test/unit/addons/test_bug428341_3/install.rdf,v
done
Checking in test/unit/addons/test_bug428341_3/install.rdf;
/cvsroot/mozilla/toolkit/mozapps/extensions/test/unit/addons/test_bug428341_3/install.rdf,v  <--  install.rdf
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/toolkit/mozapps/extensions/test/unit/addons/test_bug428341_4/install.rdf,v
done
Checking in test/unit/addons/test_bug428341_4/install.rdf;
/cvsroot/mozilla/toolkit/mozapps/extensions/test/unit/addons/test_bug428341_4/install.rdf,v  <--  install.rdf
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/toolkit/mozapps/extensions/test/unit/addons/test_bug428341_5/install.rdf,v
done
Checking in test/unit/addons/test_bug428341_5/install.rdf;
/cvsroot/mozilla/toolkit/mozapps/extensions/test/unit/addons/test_bug428341_5/install.rdf,v  <--  install.rdf
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/toolkit/mozapps/extensions/test/unit/addons/test_bug428341_6/install.rdf,v
done
Checking in test/unit/addons/test_bug428341_6/install.rdf;
/cvsroot/mozilla/toolkit/mozapps/extensions/test/unit/addons/test_bug428341_6/install.rdf,v  <--  install.rdf
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/toolkit/mozapps/extensions/test/unit/addons/test_bug428341_7/install.rdf,v
done
Checking in test/unit/addons/test_bug428341_7/install.rdf;
/cvsroot/mozilla/toolkit/mozapps/extensions/test/unit/addons/test_bug428341_7/install.rdf,v  <--  install.rdf
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/toolkit/mozapps/extensions/test/unit/addons/test_bug428341_8/install.rdf,v
done
Checking in test/unit/addons/test_bug428341_8/install.rdf;
/cvsroot/mozilla/toolkit/mozapps/extensions/test/unit/addons/test_bug428341_8/install.rdf,v  <--  install.rdf
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/toolkit/mozapps/extensions/test/unit/addons/test_bug428341_9/install.rdf,v
done
Checking in test/unit/addons/test_bug428341_9/install.rdf;
/cvsroot/mozilla/toolkit/mozapps/extensions/test/unit/addons/test_bug428341_9/install.rdf,v  <--  install.rdf
initial revision: 1.1
done

Comment 6

[Tony Chung [:tchung]]

Verified fix on Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US;
rv:1.9.1.3pre) Gecko/20090819 Shiretoko/3.5.3pre and Mozilla/5.0 (Macintosh; U;
Intel Mac OS X 10.5; en-US; rv:1.9.1.3pre) Gecko/20090819 Shiretoko/3.5.3pre