428358 - Typo in <malware-warden.js> causes xpconnect exception: "streamCompleted" -> "streamFinished"

Status: VERIFIED FIXED

(Toolkit :: Safe Browsing, defect)

Description

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Attachment: Patch [Checkin: Comment 4]

Now that we have error messages from JS components again (bug 415498) I'm seeing this in the console on startup:

[Exception... "'JavaScript component does not have a method named: "streamFinished"' when calling method: [nsIUrlClassifierUpdateObserver::streamFinished]"  nsresult: "0x80570030 (NS_ERROR_XPC_JSOBJECT_HAS_NO_FUNCTION_NAMED)"  location: "<unknown>"  data: no]

Looks like there's a typo in malware-warden.js:

http://lxr.mozilla.org/seamonkey/source/browser/components/safebrowsing/content/malware-warden.js#86

Should be streamFinished, not streamCompleted, and it has an nsresult argument. Patch attached.

Comment 1

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Comment on attachment 314906 [details] [diff] [review]
Patch
[Checkin: Comment 4]

Simple risk-free typo fix that eliminates a startup error in the JS console.

Comment 2

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 314906 [details] [diff] [review]
Patch
[Checkin: Comment 4]

a1.9=beltzner

Comment 3

[Serge Gautherie (:sgautherie)]

[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9pre) Gecko/2008041107 Minefield/3.0pre] (nightly) (W2Ksp4)

(Confirming:)
1. Load application. (any profile)

Comment 4

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Fixed.

Comment 5

[Reed Loden [:reed]]

Serge: Please don't add checkin-needed to a bug where the patch author has CVS access unless he/she has specifically requested that somebody land his/her patch(es). If you didn't know that bent has CVS access, that's fine, but please just note it for the future. :)

Comment 6

[Bill Gianopoulos [:WG9s]]

Well, shouldn't this also be fixed at http://lxr.mozilla.org/seamonkey/source/toolkit/components/url-classifier/tests/unit/head_urlclassifier.js#123 which is where I think this code was copied from in the first place?

Comment 8

[Serge Gautherie (:sgautherie)]

(In reply to comment #6)
> Well, shouldn't this also be fixed at

Right ! Thanks for noticing.

3 good files:
<http://mxr.mozilla.org/mozilla/search?string=streamFinished&tree=mozilla>
2 bad files: (before this bug)
<http://mxr.mozilla.org/seamonkey/search?string=streamCompleted&tree=seamonkey>

Comment 9

[Serge Gautherie (:sgautherie)]

Attachment: (Bv1) <head_urlclassifier.js> [Checkin: See comment 13+15]

Copy fix from <malware-warden.js> patch.

Comment 10

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Please file new bugs for new patches. It makes tracking very difficult otherwise :)

Comment 11

[Serge Gautherie (:sgautherie)]

(In reply to comment #10)
> Please file new bugs for new patches. It makes tracking very difficult
> otherwise :)

Well, what I did not do in this case is to reopen this bug...
even though I fully agree with Bill that the two files have this very bug.

Comment 12

[Serge Gautherie (:sgautherie)]

[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9pre) Gecko/2008041204 Minefield/3.0pre] (FX-WIN32-TBOX-trunk) (W2Ksp4)

V.Fixed, for the Firefox occurrence.

Comment 13

[:Gavin Sharp [email: [e-mail]]]

I fixed the same problem in the test:
mozilla/toolkit/components/url-classifier/tests/unit/head_urlclassifier.js 	1.11 

Comment 14

[Serge Gautherie (:sgautherie)]

(In reply to comment #13)
> I fixed the same problem in the test:
> mozilla/toolkit/components/url-classifier/tests/unit/head_urlclassifier.js     
> 1.11 

This checkin fixed the function name;
but you still miss the |status| parameter, don't you ?

Comment 15

[:Gavin Sharp [email: [e-mail]]]

Yeah, fixed that too. Doesn't matter too much since the function parameters aren't checked anyways.

Comment 16

[Serge Gautherie (:sgautherie)]

(In reply to comment #15)
> Yeah, fixed that too. Doesn't matter too much since the function parameters
> aren't checked anyways.

(Agreed. But it can't hurt to have it the right way ;-))