Closed Bug 428402 Opened 16 years ago Closed 16 years ago

Uncaught exception in places initialization during mochitest run

Categories

(Firefox :: Bookmarks & History, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 3

People

(Reporter: bent.mozilla, Assigned: bent.mozilla)

References

Details

Attachments

(1 file, 1 obsolete file)

Attached patch Patch (obsolete) — Splinter Review
Now that we have error messages from JS components again (bug 415498) I'm
seeing this in the console on startup when running mochitests:

[Exception... "Component returned failure code: 0x80070057 (NS_ERROR_ILLEGAL_VALUE) [nsIPlacesImportExportService.importHTMLFromFile]"  nsresult: "0x80070057 (NS_ERROR_ILLEGAL_VALUE)"  location: "JS frame :: file:///src/mozilla/trunk/cyclecollector/mozilla/compiled/browser-debug/dist/MinefieldDebug.app/Contents/MacOS/components/nsBrowserGlue.js :: bg__initPlaces :: line 429"  data: no]

This will keep some initialization code from running.

The failing line is here:
http://mxr.mozilla.org/seamonkey/source/browser/components/places/src/nsPlacesImportExportService.cpp#2231

Looks like this just needs to be converted to a try/catch instead of try/finally. See patch.
Attachment #314969 - Flags: review?(dietrich)
Comment on attachment 314969 [details] [diff] [review]
Patch

please add a Cu.reportError(err) in the catch block.

r=me otherwise
Attachment #314969 - Flags: review?(dietrich) → review+
Attached patch PatchSplinter Review
With a Cu.reportError as requested.

Drivers, simple fix that cleans up our error console on mochitest runs.
Attachment #314969 - Attachment is obsolete: true
Attachment #315855 - Flags: review+
Attachment #315855 - Flags: approval1.9?
Comment on attachment 315855 [details] [diff] [review]
Patch

a1.9=beltzner
Attachment #315855 - Flags: approval1.9? → approval1.9+
I won't be able to check this in until Tuesday, so if someone else could do it before then that would be awesome.
Status: NEW → ASSIGNED
Keywords: checkin-needed
mozilla/browser/components/nsBrowserGlue.js 	1.90 
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3
Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv
Component: Places → Bookmarks & History
QA Contact: places → bookmarks
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: