Created attachment 315070 [details] [diff] [review] Patch for extenstions/auth The extensions/auth module maintains a list of 'mailnews' protocols. Adding Kerberised LDAP support to mailnews requires the addition of the LDAP service name to this list. Mailnews also requires the use of the THREADSAFE form of NS_IMPL_ISUPPORTS The first change will not affect Firefox at all, the second is low risk for Firefox. Both changes are required in order to add Kerberised LDAP support (#308118) to Thunderbird. The change was already reviewed in bug #308118 by bienvenu
Created attachment 315118 [details] [diff] [review] Patch, with additional commentary
Comment on attachment 315118 [details] [diff] [review] Patch, with additional commentary Looks good; sr=dmose. Carrying forward bienvenu's r+ from the other bug.
Comment on attachment 315118 [details] [diff] [review] Patch, with additional commentary Requesting approval for 1.9 This bug is extremely low risk for Firefox - it doesn't change the behaviour of the existing Kerberos authentication, which is used by a very small percentage of users. These changes make it possible to add Kerberos LDAP support to Thunderbird, which is a big win for large institutions who have authenticated LDAP address books.
Comment on attachment 315118 [details] [diff] [review] Patch, with additional commentary a1.9=beltzner
Checking in extensions/auth/nsAuthGSSAPI.cpp; /cvsroot/mozilla/extensions/auth/nsAuthGSSAPI.cpp,v <-- nsAuthGSSAPI.cpp new revision: 1.14; previous revision: 1.13 done Checking in extensions/auth/nsAuthGSSAPI.h; /cvsroot/mozilla/extensions/auth/nsAuthGSSAPI.h,v <-- nsAuthGSSAPI.h new revision: 1.5; previous revision: 1.4 done Checking in extensions/auth/nsAuthSASL.cpp; /cvsroot/mozilla/extensions/auth/nsAuthSASL.cpp,v <-- nsAuthSASL.cpp new revision: 1.2; previous revision: 1.1 done Checking in extensions/auth/nsAuthSASL.h; /cvsroot/mozilla/extensions/auth/nsAuthSASL.h,v <-- nsAuthSASL.h new revision: 1.2; previous revision: 1.1 done