428533 - xul:iframe/browser/editor@type handling should happen in content, not in layout

Status: NEW

(Core :: XUL, defect)

Description

[Olli Pettay [:smaug][[e-mail]]]

Sorry for not finding/thinking this when fixing bug 395609.
I think this should block since anyone using <browser> with
some 'hidden' and 'type' attributes may easily start getting strange
behavior.

Comment 1

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Hang on, are we just talking about the code in nsSubDocumentFrame::AttributeChanged for handling dynamic changes to the "type" attribute? If we are, then I don't think this should block ... since all it means is that dynamic changes to the "type" attribute of display:none XUL frames won't be noticed, right? I would hope that dynamic changes to "type" are actually very rare...

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

(In reply to comment #1)
>I would hope that dynamic changes to "type" are actually very rare...
Happens every time a tab is switched. (Though in that case <browser> is visible.)
 

Comment 3

[Robert O'Callahan (:roc) (email my personal email if necessary)]

OK, well I still hope that dynamic changes to "type" on display:none XUL frames are rare :-), so I'd rather not block.