idl is hiding the fact QUERY_TYPE_BOOKMARKS does not support grouping atm

RESOLVED FIXED in Firefox 3.7a1

Status

()

Firefox
Bookmarks & History
RESOLVED FIXED
9 years ago
8 years ago

People

(Reporter: cmtalbert, Unassigned)

Tracking

({dev-doc-complete})

Trunk
Firefox 3.7a1
dev-doc-complete
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(status1.9.2 beta1-fixed)

Details

Attachments

(2 attachments)

(Reporter)

Description

9 years ago
Created attachment 315193 [details]
Test case demonstrating the problem

The only RESULTS_AS setting that works for Bookmark queries is RESULTS_AS_URI.  For everything else, no results are returned in the result set.  

I'll attach a test that demonstrates this behavior. 

= Expected Behavior =
The results as queries should work for bookmarks too, the RESULTS_AS_DATE* should work if the bookmarks have a visit associated with them, the RESULTS_AS_SITE should always work since bookmarks have URIs associated with them.

= Actual = 
Only RESULTS_AS_URI returns any results for a bookmark query.
Blocks: 384226
No longer depends on: 384226

Updated

8 years ago
Blocks: 509868
Created attachment 395828 [details] [diff] [review]
add idl notes

this is true, our code actually does not allow grouping bookmarks, the idl does not say anything about that, so i'm going to add notes to the idl, and this should be fixed in future if possible adding support for more complex queries (rewriting the query builder class could make this easier).
Attachment #395828 - Flags: review?(dietrich)
(In reply to comment #1)
> this is true, our code actually does not allow grouping bookmarks, the idl does
> not say anything about that, so i'm going to add notes to the idl, and this
> should be fixed in future if possible adding support for more complex queries
> (rewriting the query builder class could make this easier).

please file a bug for this change, and make it block the query-builder-rewrite bug.
Comment on attachment 395828 [details] [diff] [review]
add idl notes

clear enough, r=me
Attachment #395828 - Flags: review?(dietrich) → review+
morphing the bug, this will handle idl comment only, i'll file a separate one for grouping
Summary: RESULTS_AS* not working for queries of type QUERY_TYPE_BOOKMARKS → idl is hiding the fact QUERY_TYPE_BOOKMARKS does not support grouping atm
http://hg.mozilla.org/mozilla-central/rev/b068cbe50c07
Status: NEW → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3.7a1
http://hg.mozilla.org/releases/mozilla-1.9.2/rev/668a8979b530
status1.9.2: --- → beta1-fixed
Keywords: dev-doc-needed
Updated the docs here:

https://developer.mozilla.org/en/nsINavHistoryQueryOptions#Result_type_constants
Keywords: dev-doc-needed → dev-doc-complete
Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv
Component: Places → Bookmarks & History
QA Contact: places → bookmarks
You need to log in before you can comment on or make changes to this bug.