Closed
Bug 428666
Opened 17 years ago
Closed 17 years ago
Save Page As saves "Web Page, complete" even when I select "HTML only" when using the toolkit file picker
Categories
(Core Graveyard :: File Handling, defect)
Core Graveyard
File Handling
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla1.9
People
(Reporter: MatsPalmgren_bugz, Assigned: MatsPalmgren_bugz)
References
Details
(Keywords: regression)
Attachments
(1 file)
1.29 KB,
patch
|
timeless
:
review+
mtschrep
:
approval1.9+
|
Details | Diff | Splinter Review |
Save Page As saves "Web Page, Complete" when using the toolkit file picker even when I select "HTML Only".
STEPS TO REPRODUCE
1. start Firefox with a clean profile
2. about:config
3. set "ui.allow_platform_file_picker" to false
4. visit any page
5. Save Page As
6. in file picker: enter a file name, select "Web Page, HTML only", Save
ACTUAL RESULTS
Page is saved as "Web Page, complete".
EXPECTED RESULTS
A single HTML file with the original page contents please.
PLATFORMS AND BUILDS TESTED
Bug occurs in Firefox 2008041104 on Linux.
Comment 1•17 years ago
|
||
Do you happen to know roughly when this regressed?
Assignee | ||
Comment 2•17 years ago
|
||
Regression window: 2008-02-26-04 -- 2008-02-27-04
http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=all&branch=HEAD&branchtype=match&dir=&file=&filetype=match&who=&whotype=match&sortby=Date&hours=2&date=explicit&mindate=2008-02-26+03%3A00&maxdate=2008-02-27+05%3A00&cvsroot=%2Fcvsroot
I also noticed that the 2008-02-27-04 build does not remember the last
value used for "Web Page, complete"/"Web Page, HTML only" after a restart.
2008-02-26-04 does remember the last selected value, maybe that's got
something to do with it...
Assignee | ||
Comment 3•17 years ago
|
||
Bug 412822 seems to be the culprit. Specifically the change from:
- var filterMenuList = document.getElementById("filterMenuList");
- retvals.filterIndex = filterMenuList.selectedIndex;
to:
+ retvals.filterIndex = document.getElementById("filterMenuList");
in toolkit/components/filepicker/content/filepicker.js
OS: Linux → All
Hardware: PC → All
Assignee | ||
Comment 4•17 years ago
|
||
This fixes it for me.
Attachment #315289 -
Flags: review?(timeless)
Comment on attachment 315289 [details] [diff] [review]
Patch rev. 1
hrm, sorry. i wonder if that was a merge conflict.
Attachment #315289 -
Flags: review?(timeless) → review+
Assignee | ||
Comment 6•17 years ago
|
||
Comment on attachment 315289 [details] [diff] [review]
Patch rev. 1
Zero risk (typo).
Attachment #315289 -
Flags: approval1.9?
Assignee | ||
Updated•17 years ago
|
Assignee: nobody → mats.palmgren
Updated•17 years ago
|
Attachment #315289 -
Flags: approval1.9? → approval1.9+
Assignee | ||
Comment 7•17 years ago
|
||
mozilla/toolkit/components/filepicker/content/filepicker.js 1.21
-> FIXED
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9
Updated•8 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•