428813 - Installer: Add a "Summary" last step before actual install, like Thunderbird has

Status: VERIFIED FIXED

(SeaMonkey :: Installer, defect)

Description

[Serge Gautherie (:sgautherie)]

I downloaded "2008-04-13-02-trunk"
<seamonkey-2.0a1pre.en-US.win32.installer.exe>,
and "2008-04-13-03-trunk" <thunderbird-3.0a1pre.en-US.win32.installer.exe>.

After either "Standard" or "Custom" choice,
TB has a summary page before actually installing,
which gives a chance to modify/cancel installation.

SM should have that too !

(I thought I might have already filed a bug like this some time ago, but I don't find it, so...)

Comment 1

[Serge Gautherie (:sgautherie)]

With the "Standard" option, this is even misleading as the button says "Next" instead of "Install".

Comment 2

[Serge Gautherie (:sgautherie)]

Regression: (from the switch to "Toolkit")

"2007-05-29-09-trunk" <seamonkey-1.5a.en-US.win32.installer.exe>, "Complete" option, has such a page.

"2007-05-29-14-trunk" <seamonkey-2.0a1pre.en-US.win32.installer.exe>, "Standard" option, is missing this page.

Comment 3

[Vlado Valastiak [:wladow]]

Attachment: add Summary page

This adds Summary page using shared toolkit code added in bug 396870

It currently shows only install location, more to come once bug 397119 is fixed.

Comment 4

[Vlado Valastiak [:wladow]]

Attachment: screenshot

Comment 5

[Serge Gautherie (:sgautherie)]

(In reply to comment #3)
> Created an attachment (id=316637) [details]
> add Summary page
> 
> This adds Summary page using shared toolkit code added in bug 396870

Perfect :-)

> It currently shows only install location, more to come once bug 397119 is
> fixed.

Thanks for the hint:
SM v2 does miss the other details (too) compared to SM v1.1.

Comment 6

[Frank Wein [:mcsmurf]]

Comment on attachment 316637 [details] [diff] [review]
add Summary page

Looks ok, r+.

Comment 7

[Frank Wein [:mcsmurf]]

Checking in locales/en-US/installer/windows/custom.properties;
/cvsroot/mozilla/suite/locales/en-US/installer/windows/custom.properties,v  <--  custom.properties
new revision: 1.8; previous revision: 1.7
done
Checking in installer/windows/nsis/installer.nsi;
/cvsroot/mozilla/suite/installer/windows/nsis/installer.nsi,v  <--  installer.nsi
new revision: 1.13; previous revision: 1.12
done

Comment 8

[Serge Gautherie (:sgautherie)]

[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9pre) Gecko/2008051807 SeaMonkey/2.0a1pre] (SEA-WIN32-TBOX-trunk) (W2Ksp4)

V.Fixed

Comment 9

[Stefan [:stefanh]]

Vlado should have been mentioned in the check-in comment.