Installer creates wrong Start Mail link

VERIFIED FIXED in seamonkey2.0a1

Status

--
major
VERIFIED FIXED
11 years ago
11 years ago

People

(Reporter: sgautherie, Assigned: sgautherie)

Tracking

({regression})

Trunk
seamonkey2.0a1
x86
Windows 2000
regression

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Assignee)

Description

11 years ago
Bug 428812 comment 0:
{{
2. In the Windows Start menu, the mail item links to
<"C:\Documents and Settings\...\Bureau\-mail" C:\Program
Files\SeaMonkey\seamonkey.exe>
2r. The first path should probably not be there at all; the parameter should be
at the end.
}}

***

Regression: (from the switch to "Toolkit")

"2007-05-29-09-trunk" <seamonkey-1.5a.en-US.win32.installer.exe>, "Complete"
option, creates good link.

"2007-05-29-14-trunk" <seamonkey-2.0a1pre.en-US.win32.installer.exe>,
"Standard" option, creates bad link.
Flags: blocking-seamonkey2.0a1?
(Assignee)

Comment 1

11 years ago
Created attachment 315396 [details] [diff] [review]
(Av1) Cleanup: removes redundant |MAILNEWS|
[Checkin: Comment 4]

|MAILNEWS_TEXT| seems enough...
Attachment #315396 - Flags: superreview?(neil)
Attachment #315396 - Flags: review?(bugzilla)
(Assignee)

Updated

11 years ago
Blocks: 351917
(Assignee)

Comment 2

11 years ago
Created attachment 315398 [details] [diff] [review]
(Bv1) <installer.nsi> Add missing argument
[Checkin: Comment 4]
Assignee: nobody → sgautherie.bz
Status: NEW → ASSIGNED
Attachment #315398 - Flags: superreview?(neil)
Attachment #315398 - Flags: review?(bugzilla)
(Assignee)

Comment 3

11 years ago
Both patches are untested, as I don't have a build environment.

Updated

11 years ago
Attachment #315396 - Flags: superreview?(neil) → superreview+

Updated

11 years ago
Attachment #315398 - Flags: superreview?(neil) → superreview+

Updated

11 years ago
Attachment #315396 - Flags: review?(bugzilla) → review+

Updated

11 years ago
Attachment #315398 - Flags: review?(bugzilla) → review+
(Assignee)

Updated

11 years ago
Keywords: checkin-needed
Whiteboard: [c-n: Av1, Bv1]
Av1:

Checking in suite/installer/windows/nsis/installer.nsi;
/cvsroot/mozilla/suite/installer/windows/nsis/installer.nsi,v  <--  installer.nsi
new revision: 1.10; previous revision: 1.9
done
Checking in suite/locales/en-US/installer/windows/custom.properties;
/cvsroot/mozilla/suite/locales/en-US/installer/windows/custom.properties,v  <--  custom.properties
new revision: 1.7; previous revision: 1.6
done

Bv1:

Checking in suite/installer/windows/nsis/installer.nsi;
/cvsroot/mozilla/suite/installer/windows/nsis/installer.nsi,v  <--  installer.nsi
new revision: 1.11; previous revision: 1.10
done
Status: ASSIGNED → RESOLVED
Last Resolved: 11 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Whiteboard: [c-n: Av1, Bv1]
(Assignee)

Comment 5

11 years ago
[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9pre) Gecko/2008050708 SeaMonkey/2.0a1pre] (SEA-WIN32-TBOX-trunk) (W2Ksp4)

V.Fixed.
Status: RESOLVED → VERIFIED
Flags: blocking-seamonkey2.0a1?
(Assignee)

Updated

11 years ago
Attachment #315396 - Attachment description: (Av1) Cleanup: removes redundant |MAILNEWS| → (Av1) Cleanup: removes redundant |MAILNEWS| [Checkin: Comment 4]
(Assignee)

Updated

11 years ago
Attachment #315398 - Attachment description: (Bv1) <installer.nsi> Add missing argument → (Bv1) <installer.nsi> Add missing argument [Checkin: Comment 4]
You need to log in before you can comment on or make changes to this bug.