428851 - Accepting Meeting Invites Does Not Update Google Calendar

Status: RESOLVED FIXED

(Calendar :: Provider: GData, defect)

Description

[Mike DePriest]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.1.13) Gecko/20061201 Firefox/2.0.0.13 (Ubuntu-feisty)
Build Identifier: Provider 0.4 Lightning 0.8 2008033118 TB 2.0.0.12 20080213

If I receive a meeting invitation from an Outlook user and "Accept" the invitation, I do not get a new event on the chosen Google Calendar.

This worked in earlier versions of Provider and Lightning.

Events created in Lightning are transferred to Google just fine, and vice-versa.

Error console messages and ICS file contents are as follows:

---

Getting item with id 040000008200E00074C5B7101A82E00800000000101EE73D7199C801000000000000000010000000F848678457842240B66BC9B402DE766A

calGoogleRequest: Requesting GET http://www.google.com/calendar/feeds/mike.depriest%40gmail.com/private/full?max-results=2147483647&singleevents=false

Error parsing XML streamTypeError: item.startDate has no properties

Error getting item undefined:
TypeError: item.startDate has no properties

--- 

BEGIN:VCALENDAR
PRODID:-//Microsoft Corporation//Outlook 11.0 MIMEDIR//EN
VERSION:2.0
METHOD:REQUEST
BEGIN:VEVENT
ATTENDEE;ROLE=REQ-PARTICIPANT;RSVP=TRUE:MAILTO:[e-mail]
ORGANIZER:MAILTO:[e-mail]
DTSTART:20080408T203000Z
DTEND:20080408T210000Z
LOCATION:Ed will Call Mike and Richard - It might be best if Richard was
  with Mike in Mike's Office
TRANSP:OPAQUE
SEQUENCE:0
UID:040000008200E00074C5B7101A82E00800000000101EE73D7199C8010000000000000000100
 00000F848678457842240B66BC9B402DE766A
DTSTAMP:20080408T160822Z
DESCRIPTION:When: Tuesday\, April 08\, 2008 4:30 PM-5:00 PM (GMT-05:00)
  Eastern Time (US & Canada).\nWhere: Ed will Call Mike and Richard - It
  might be best if Richard was with Mike in Mike's
  Office\n\n*~*~*~*~*~*~*~*~*~*\n\nTiming:  4:30 PM Eastern / 3:30 PM
  Central\n\nI will call Mike's Office.  It would be best if Richard and
  Mike were in there together.\n\nGiven Ron's limited availability and
  on-going access problems\, I'm not sure that our current plan to complete
  the XXXXXX XXX User Documentation will meet XXXXXX's timeline (completion
  by April 23).  \n\nI'd like to explore our options (engaging Daniel\,
  Pat\, etc.) to improve that plan and manage our risk.\n
SUMMARY:Plan to Update XXXXXX XXX User Documentation
PRIORITY:1
X-MICROSOFT-CDO-IMPORTANCE:2
CLASS:PUBLIC
BEGIN:VALARM
TRIGGER:-PT15M
ACTION:DISPLAY
DESCRIPTION:Reminder
END:VALARM
END:VEVENT
END:VCALENDAR



Reproducible: Always

Steps to Reproduce:
1. Accept meeting invitation in Thunderbird by clicking "Accept" button

2. Select a Google Calendar as the event calendar
Actual Results:  
No event created in Google Calendar

Expected Results:  
Event created in Google Calendar conforming to the invitation

The behavior is the same whether the calendar.google.enableAttendees setting is true or false.

Comment 2

[Philipp Kewisch [:Fallen][📱📆]]

There is also more debug info mentioned in bug 429090, which may help find the problem. Confirming based on duplicate.

Comment 3

[Philipp Kewisch [:Fallen][📱📆]]

Attachment: Fix v1

This should fix it. The item entry was not correctly being passed.

Comment 4

[Philipp Kewisch [:Fallen][📱📆]]

Comment on attachment 316380 [details] [diff] [review]
Fix v1

I take that back...

Comment 5

[Philipp Kewisch [:Fallen][📱📆]]

Attachment: Fix - v2

This should do better...

Comment 6

[Daniel Boelzle [:dbo]]

Comment on attachment 316581 [details] [diff] [review]
Fix - v2

r=dbo

Comment 7

[Philipp Kewisch [:Fallen][📱📆]]

Checked in on HEAD and MOZILLA_1_8_BRANCH

-> FIXED

Comment 8

[Cosmin Achim]

can anyone tell me where can I found a build which includes this fix ?

Comment 9

[Philipp Kewisch [:Fallen][📱📆]]

ftp://ftp.mozilla.org/pub/calendar/lightning/nightly/latest-mozilla1.8/

Comment 10

[Philipp Kewisch [:Fallen][📱📆]]

I haven't done so yet, but I'm going to have to back parts of this change out. When splitting a recurring event by modifying "All Following" via the Google Web Interface, all extended properties are cloned for the new event. This also means the X-MOZ-SYNCID property is cloned, which in turn means that the cloned event will not show up in lightning, since internally it uses X-MOZ-SYNCID as the id, which already exists.

Having decent meeting invitation support really depends on Google sorting out their issues and providing a good invitations API and/or fixing their syncEvent/gCal::uid/... stuff.

Comment 11

[Philipp Kewisch [:Fallen][📱📆]]

Attachment: Disallow adding bad items to calendar - v2

This is about as far as I'm willing to go towards working around server bugs. I have disallowed storing an item in a Google Calendar from the client side if it was received via imip. This doesn't mean that its not possible to receive invitations though. The "cure" is to enable "show invitations in calendar" in your Google settings, which puts the items already in your calendar. You can then accept the event as usual with the invitations dialog. The imip email you get will state that the event is already in your calendar.

I've done some code cleanup, fixed bug 452818 and bug 409967, fixed an issue with returning invitations in getItems(), aligned the constants in calIGoogleRequest with those from calIOperationListener to make it easier to notify the right operation type.

This depends on bug 453195.

Comment 12

[Philipp Kewisch [:Fallen][📱📆]]

Attachment: Disallow adding bad items to calendar - v2

Oops, wrong patch.

Comment 13

[Philipp Kewisch [:Fallen][📱📆]]

Attachment: Screenshot linux

Comment 14

[Daniel Boelzle [:dbo]]

Comment on attachment 336383 [details] [diff] [review]
Disallow adding bad items to calendar - v2

>     /* Constants */
>-    LOGIN: 1,
>-    GET: 2,
>-    ADD: 3,
>-    MODIFY: 4,
>-    DELETE: 5,
>+    LOGIN: 0,
>+    ADD: 1,
>+    MODIFY: 2,
>+    DELETE: 3,
>+    GET: 4,
Why don't you use the IDL constants throughout the code?

looks good, though untested; r=dbo

Comment 15

[Philipp Kewisch [:Fallen][📱📆]]

Comment on attachment 336384 [details]
Screenshot linux

I've decided to check this in without waiting for ui-r, since we are branching soon. I'd like to have this patch in before that step.

Christian, if you would like anything changed please let me know.

Comment 16

[Philipp Kewisch [:Fallen][📱📆]]

Checked in on HEAD and MOZILLA_1_8_BRANCH

-> FIXED

Comment 17

[Christian Jansen]

Comment on attachment 336384 [details]
Screenshot linux

ui=christian