Yahoo Mail mailto: handler doesn't have an icon.

RESOLVED FIXED

Status

()

--
minor
RESOLVED FIXED
11 years ago
2 years ago

People

(Reporter: Dolske, Unassigned)

Tracking

Trunk
Points:
---
Dependency tree / graph
Bug Flags:
in-litmus +

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

11 years ago
When selecting Yahoo Mail as a protocol handler for mailto (in Preferences -> Application), the dropdown doesn't have an icon (favicon). There's an icon for 30 Boxes with webcal, so I assume we just didn't land one for Yahoo.

Alex says he has a PNG that was approved for the Yahoo search plugin, and mail.yahoo.com seems to be the same, so using that should presumably be fine.
Looks like yahoo actually wasn't in the set that Kev gave me.  Can we just convert their favicon to a png.
kev: any chance you could get us an approved yahoo icon really quickly?
(Reporter)

Comment 3

11 years ago
Hmm, ugh...

browser/components/preferences/applications.js, _getIconURLForWebApp() just takes the handler URI's prepath, appends "favicon.ico", and remotely loads the image into chrome. We don't actually ship an icon.

So, that technically makes this a server-side problem, although having chrome UI remotely load icons for menus doesn't seem like a good idea.

Comment 4

11 years ago
And the plethora of redirects on yahoo mail doesn't help. I just tried to load that URL, too, not productive :-).

There's a favicon service, should we use that instead? Would that help with the redirects, though?

Updated

11 years ago
Flags: in-litmus?
The Yahoo icon is also missing from the Launch Application dialog - will this bug address that issue as well? Also I noticed that all icons are missing from launch application - Thunderbird, etc. I can file a separate bug for that since I did not see an existing one.

Updated

11 years ago
Flags: in-litmus? → in-litmus+
(In reply to comment #5)
> The Yahoo icon is also missing from the Launch Application dialog - will this
> bug address that issue as well? Also I noticed that all icons are missing from
> launch application - Thunderbird, etc. I can file a separate bug for that since
> I did not see an existing one.
It should fix both ideally.

(In reply to comment #4)
> There's a favicon service, should we use that instead? Would that help with the
> redirects, though?
That's worth investigating, but isn't always reliable (or so I was told ~a year ago)
>I noticed that all icons are missing from
>launch application - Thunderbird, etc. I can file a separate bug for that since
>I did not see an existing one.

Can you link to that bug here?

Yikes, the Launch Application window kind of looks like alpha level polish, filed follow up bug 445639
Flags: wanted-firefox3.1?

Comment 8

10 years ago
Whatever we do here icon-wise should also work for the DOM-added protocol handlers. Content handlers seem to be loading the icons from the net, not sure if there's any better way to do that, or to cache them.
(Reporter)

Comment 9

10 years ago
(not actively working on this)
Assignee: dolske → nobody
Target Milestone: Firefox 3 → ---
Flags: wanted-firefox3.5?
Found this from another bug, it appears to be fixed now. Closing.
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.