428925 - Crash when I try to hide menu dynamically [@ nsMenuX::ObserveAttributeChanged]

Status: RESOLVED WORKSFORME

(Core :: Widget: Cocoa, defect)

Description

[Vivekanand Bolajwar]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.13) Gecko/20080326 Firefox/2.0.0.13 Flock/1.1.1
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.13) Gecko/20080326 Firefox/2.0.0.13 Flock/1.1.1

I have added new (extension specific) menu to Firefox's default menu set. I have also added a button which shows/hides the extension specific menu. It works well in Firefox 2.* but when I am trying the same on Firefox 3 Beta 5, its crashing.

Then i tried hiding every menu from Firefox menubar dynamically by setting hidden="true" and noticed that for every menu its crashing.

Reproducible: Always

Steps to Reproduce:
1. Add new menu to firefox menubar
2. After loading of firefox on any event try to hide the added menu
3. Try setting hidden="true" for the added menu.
Actual Results:  
Firefox crashes.

Expected Results:  
Menu should disappear.

Comment 1

[Matthias Versen [:Matti]]

Please provide a crash id from about:crashes in Firefox3b5.

Comment 2

[Arie Paap [:wildmyron]]

In addition to comment 1, can you please clarify the following points:

1) OS is MacOS but you filed this bug from Windows. Does the crash occur on Fx3b5 on Windows, on MacOS or both?

2) Is there a version of your extension which causes the crash available publicly? if not, please attach it here (or preferably a cut down extension that also crashes Fx)

3) what kind of event is required in step 2

For reference I was not able to reproduce crash using DOMi to hide menu entries with Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9pre) Gecko/2008040204 Minefield/3.0pre ID:2008040204

Comment 3

[Vivekanand Bolajwar]

Crash Id is
http://crash-stats.mozilla.com/report/index/23380340-0a0a-11dd-877c-0013211cbf8a

1. Yes. It crashes on MacOS 10.5
2. Yes. I am using Firefox 3 beta 5 which is publicly available
3. Event could be any user action. In my case its "onclick" of the button.

I am new to community but I believe when I specify OS in the filed bug its obvious that I have noticed the bug on specified OS only. :)

Thanks for the quick reply.

Comment 4

[Vivekanand Bolajwar]

Attachment: The Test Extension that tries to hide the menu dynamically and crashes on MAC

As you requested I have created a small extension which simply tries to hide the bookmarks menu and crashes Firefox on MAC.

Comment 5

[Arie Paap [:wildmyron]]

Thanks for additional information, and test extension:

From your crash report this is Mac only, so I can't confirm, but sending over
to Core->Widget:Cocoa

stack trace:
bp-23380340-0a0a-11dd-877c-0013211cbf8a
Frame   Module          Signature [Expand]      Source
0       XUL     nsObjCExceptionLogAbort        
mozilla/widget/src/cocoa/nsMenuX.mm:63
1       XUL     nsMenuX::ObserveAttributeChanged       
mozilla/widget/src/cocoa/nsMenuX.mm:1077
2       XUL     nsNodeUtils::AttributeChanged  
mozilla/content/base/src/nsNodeUtils.cpp:107
3       XUL     nsGenericElement::SetAttrAndNotify     
mozilla/content/base/src/nsGenericElement.cpp:3779
4       XUL     nsGenericElement::SetAttr      
mozilla/content/base/src/nsGenericElement.cpp:3707
5       XUL     nsGenericElement::SetAttribute 
mozilla/content/base/src/nsGenericElement.cpp:1591
6       XUL     NS_InvokeByIndex_P     
mozilla/xpcom/reflect/xptcall/src/md/unix/xptcinvoke_unixish_x86.cpp:179
7       XUL     XPCWrappedNative::CallMethod   
mozilla/js/src/xpconnect/src/xpcwrappednative.cpp:2369
8       XUL     XPC_WN_CallMethod      
mozilla/js/src/xpconnect/src/xpcwrappednativejsops.cpp:1470
9       libmozjs.dylib  js_Invoke       mozilla/js/src/jsinvoke.c:1287
10      libmozjs.dylib  js_Interpret    mozilla/js/src/jsinterp.c:4841

Comment 6

[Vivekanand Bolajwar]

I still see the bug as unconfirmed!

Can anyone shed more light on what is the current status?

Comment 7

[Matthias Versen [:Matti]]

The current status is "unconfirmed", it will change if a developer looks at this.
"still unconfirmed" can be used after a few months but not after a half month.

Comment 8

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Have you tested this in a recent nightly build?  Steven has fixed a couple of menu-update-related bugs recently.

Comment 9

[Vivekanand Bolajwar]

Yes, I did installed latest nightly build and I could see the issues is still there.

As we are planning to release our extension soon I hope this will get fixed which is stopping us from releasing the extension. After all we cant give an extension that crashes Firefox ;)

Comment 10

[Steven Michaud [:smichaud] (Retired)]

I will try to find time in the next few days to look into this -- at
least to use the text extension from comment #4 to confirm (or fail to
confirm) this report.

But I can already say that, even if this is our bug, it's unlikely
that a fix for it will get into Firefox 3 -- since we're so close to
the Firefox 3 release.

A more reasonable (and plausible) target is the first point release
after Firefox 3.

Comment 11

[Wayne Mery (:wsmwk)]

here is one crash from 3.1b2 bp-c239be0e-31e4-4d17-ae0c-cd1872090411
it still occurs, but is by no means topcrash, on v3.0.8

Comment 12

[Wayne Mery (:wsmwk)]

 Vivekanand, Frankie, does this still reproduce?


Nothing on crash-stats, but that's not unexpected

Comment 13

[Vivekanand Bolajwar]

Wayne,

I guess its fixed in recent versions of Firefox. I am on FF18 and cant reproduce it.

Closing the ticket as works for me.