428957 - Group position not correct for list items and options

Status: VERIFIED FIXED

(Core :: Disability Access APIs, defect)

Description

[Aaron Leventhal]

We use object attribute and IA2::groupPosition() to provide information about a the number of items in a group of similar widgets and the item # of each.

This info is not being correctly calculated for list item and option.

Comment 1

[Aaron Leventhal]

Attachment: Get whitelists of roles correct for ::GetAttributes()

Comment 2

[alexander :surkov (:asurkov)]

Comment on attachment 315551 [details] [diff] [review]
Get whitelists of roles correct for ::GetAttributes()


>       role == nsIAccessibleRole::ROLE_MENUITEM ||
>       role == nsIAccessibleRole::ROLE_LISTITEM ||
>+      role == nsIAccessibleRole::ROLE_OPTION ||
>+      role == nsIAccessibleRole::ROLE_RADIOBUTTON ||
>+      role == nsIAccessibleRole::ROLE_RICH_OPTION ||
>       role == nsIAccessibleRole::ROLE_OUTLINEITEM ||

that's fine.

>       content->HasAttr(kNameSpaceID_None, nsAccessibilityAtoms::aria_checked)) {
>     // Might be checkable -- checking role & ARIA attribute first is faster than getting state

>         role == nsIAccessibleRole::ROLE_PAGETAB ||
>+        role == nsIAccessibleRole::ROLE_OPTION ||
>+        role == nsIAccessibleRole::ROLE_RADIOBUTTON ||
>+        role == nsIAccessibleRole::ROLE_RICH_OPTION ||
>         role == nsIAccessibleRole::ROLE_OUTLINEITEM) &&
>         0 == (State(this) & nsIAccessibleStates::STATE_INVISIBLE)) {
>       nsCOMPtr<nsIAccessible> parent = GetParent();

I'm not sure about ROLE_RICH_OPTION because it's not used by ARIA but usually we rewrite group position calculating for certain widgets. Don't we do in this case?

Comment 3

[Aaron Leventhal]

Attachment: Address Surkov's comment -- we don't need RICH_LIST_OPTION because it sets these attributes in SetAccAttrsForXULSelectControlItem()

Comment 4

[alexander :surkov (:asurkov)]

Comment on attachment 315630 [details] [diff] [review]
Address Surkov's comment -- we don't need RICH_LIST_OPTION because it sets these attributes in SetAccAttrsForXULSelectControlItem()

r=me

Comment 5

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 315630 [details] [diff] [review]
Address Surkov's comment -- we don't need RICH_LIST_OPTION because it sets these attributes in SetAccAttrsForXULSelectControlItem()

a1.9=beltzner

Comment 6

[Marco Zehe (:MarcoZ)]

Verified fixed using Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9pre) Gecko/2008041606 Minefield/3.0pre