Closed Bug 428970 Opened 12 years ago Closed 12 years ago

Implement --disable-vista-sdk-requirements configure option and update source to use it

Categories

(Firefox :: Shell Integration, defect)

x86
Windows Vista
defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 3

People

(Reporter: jimm, Assigned: jimm)

References

Details

(Whiteboard: [licensing issue see bug 397678 comment 44])

Attachments

(2 files, 3 obsolete files)

Flags: wanted-firefox3+
Flags: blocking-firefox3?
Flags: blocking-firefox3-
I should have checked the discussion before making my decision. Yes, this blocks.
Flags: wanted-firefox3+
Flags: blocking-firefox3-
Flags: blocking-firefox3+
Whiteboard: [licensing issue see bug 397678 comment 44]
Attached patch sdk update v.1 (obsolete) — Splinter Review
Attached patch sdk update v.2 (obsolete) — Splinter Review
Attachment #317036 - Attachment is obsolete: true
Attached patch sdk update v.3 (obsolete) — Splinter Review
updated sunbird and lightning mozconfigs
Attachment #317046 - Attachment is obsolete: true
Attached patch sdk update v.4Splinter Review
Attachment #317076 - Attachment is obsolete: true
Attachment #317117 - Flags: review?(robert.bugzilla)
Attachment #317117 - Flags: review?(benjamin)
Tested on msvc 8 w/ vista sdk and msvc 7.1 w/2003 R2 sdk. Also tested the various ac options flags, and ran the browser portion through the try server.
 
Comment on attachment 317117 [details] [diff] [review]
sdk update v.4

I did a quick once over and this looks fine. I'll do a more thorough review later.
Whiteboard: [licensing issue see bug 397678 comment 44] → [licensing issue see bug 397678 comment 44][has patch][needs review rstrong/bsmedberg]
Attachment #317117 - Flags: review?(benjamin) → review+
Attachment #317117 - Flags: approval1.9?
Comment on attachment 317117 [details] [diff] [review]
sdk update v.4

a1.9=beltzner
Attachment #317117 - Flags: approval1.9? → approval1.9+
Keywords: checkin-needed
Whiteboard: [licensing issue see bug 397678 comment 44][has patch][needs review rstrong/bsmedberg] → [licensing issue see bug 397678 comment 44]
Whiteboard: [licensing issue see bug 397678 comment 44] → [licensing issue see bug 397678 comment 44][has approval]
Whiteboard: [licensing issue see bug 397678 comment 44][has approval] → [licensing issue see bug 397678 comment 44][has patch][has approval]
mozilla/browser/components/shell/src/nsWindowsShellService.cpp 	1.56
mozilla/browser/components/shell/src/nsWindowsShellService.h 	1.15
mozilla/config/autoconf.mk.in 	3.461
mozilla/uriloader/exthandler/Makefile.in 	1.74
mozilla/mail/components/shell/nsMailWinIntegration.cpp 	1.10
mozilla/tools/tinderbox-configs/lightning/win32/mozconfig 	1.6
mozilla/uriloader/exthandler/win/nsOSHelperAppService.cpp 	1.85
mozilla/uriloader/exthandler/win/nsOSHelperAppService.h 	1.33
mozilla/suite/shell/src/nsWindowsShellService.cpp 	1.4
mozilla/tools/tinderbox-configs/sunbird/win32/mozconfig 	1.36
mozilla/configure.in 	1.1987
Status: NEW → RESOLVED
Closed: 12 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Whiteboard: [licensing issue see bug 397678 comment 44][has patch][has approval] → [licensing issue see bug 397678 comment 44]
Target Milestone: --- → Firefox 3
Comment on attachment 317117 [details] [diff] [review]
sdk update v.4

>Index: mail/components/shell/nsMailWinIntegration.cpp
>===================================================================
>RCS file: /cvsroot/mozilla/mail/components/shell/nsMailWinIntegration.cpp,v
>retrieving revision 1.9
>diff -u -p -8 -r1.9 nsMailWinIntegration.cpp
>--- mail/components/shell/nsMailWinIntegration.cpp	11 Jul 2007 05:59:57 -0000	1.9
>+++ mail/components/shell/nsMailWinIntegration.cpp	22 Apr 2008 22:37:59 -0000
>@@ -638,64 +644,20 @@ nsWindowsShellService::setKeysForSetting
>   HRESULT hr = CoCreateInstance (CLSID_ApplicationAssociationReg,
>                                  NULL,
>                                  CLSCTX_INPROC,
>                                  IID_IApplicationAssociationReg,
>                                  (void**)&pAAR);

The 2 |*ApplicationAssociationReg| must be renamed here too !
Attached patch followupSplinter Review
mozilla/mail/components/shell/nsMailWinIntegration.cpp 	1.11
Crap, sorry. search and replace let me down. 
If anyone on this has delete access to cvs, could you please remove - 

uriloader/exthandler/win/IApplicationAssociationRegistration.h  

(In reply to comment #13)
> If anyone on this has delete access to cvs, could you please remove - 
> uriloader/exthandler/win/IApplicationAssociationRegistration.h  

Done.
You need to log in before you can comment on or make changes to this bug.