Implement --disable-vista-sdk-requirements configure option and update source to use it

RESOLVED FIXED in Firefox 3

Status

()

RESOLVED FIXED
11 years ago
10 years ago

People

(Reporter: jimm, Assigned: jimm)

Tracking

Trunk
Firefox 3
x86
Windows Vista
Points:
---
Dependency tree / graph
Bug Flags:
blocking-firefox3 +

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [licensing issue see bug 397678 comment 44])

Attachments

(2 attachments, 3 obsolete attachments)

Flags: wanted-firefox3+
Flags: blocking-firefox3?
Flags: blocking-firefox3-
I should have checked the discussion before making my decision. Yes, this blocks.
Flags: wanted-firefox3+
Flags: blocking-firefox3-
Flags: blocking-firefox3+
Whiteboard: [licensing issue see bug 397678 comment 44]
(Assignee)

Comment 2

11 years ago
Created attachment 317036 [details] [diff] [review]
sdk update v.1
(Assignee)

Comment 3

11 years ago
Created attachment 317046 [details] [diff] [review]
sdk update v.2
Attachment #317036 - Attachment is obsolete: true
(Assignee)

Comment 4

11 years ago
Created attachment 317076 [details] [diff] [review]
sdk update v.3

updated sunbird and lightning mozconfigs
Attachment #317046 - Attachment is obsolete: true
(Assignee)

Comment 5

11 years ago
Created attachment 317117 [details] [diff] [review]
sdk update v.4
Attachment #317076 - Attachment is obsolete: true
Attachment #317117 - Flags: review?(robert.bugzilla)
(Assignee)

Updated

11 years ago
Attachment #317117 - Flags: review?(benjamin)
(Assignee)

Comment 6

11 years ago
Tested on msvc 8 w/ vista sdk and msvc 7.1 w/2003 R2 sdk. Also tested the various ac options flags, and ran the browser portion through the try server.
 
Comment on attachment 317117 [details] [diff] [review]
sdk update v.4

I did a quick once over and this looks fine. I'll do a more thorough review later.

Updated

11 years ago
Whiteboard: [licensing issue see bug 397678 comment 44] → [licensing issue see bug 397678 comment 44][has patch][needs review rstrong/bsmedberg]

Updated

11 years ago
Attachment #317117 - Flags: review?(benjamin) → review+
Attachment #317117 - Flags: review?(robert.bugzilla) → review+
(Assignee)

Updated

11 years ago
Attachment #317117 - Flags: approval1.9?
Comment on attachment 317117 [details] [diff] [review]
sdk update v.4

a1.9=beltzner
Attachment #317117 - Flags: approval1.9? → approval1.9+
(Assignee)

Updated

11 years ago
Keywords: checkin-needed
Whiteboard: [licensing issue see bug 397678 comment 44][has patch][needs review rstrong/bsmedberg] → [licensing issue see bug 397678 comment 44]
Whiteboard: [licensing issue see bug 397678 comment 44] → [licensing issue see bug 397678 comment 44][has approval]

Updated

10 years ago
Whiteboard: [licensing issue see bug 397678 comment 44][has approval] → [licensing issue see bug 397678 comment 44][has patch][has approval]
mozilla/browser/components/shell/src/nsWindowsShellService.cpp 	1.56
mozilla/browser/components/shell/src/nsWindowsShellService.h 	1.15
mozilla/config/autoconf.mk.in 	3.461
mozilla/uriloader/exthandler/Makefile.in 	1.74
mozilla/mail/components/shell/nsMailWinIntegration.cpp 	1.10
mozilla/tools/tinderbox-configs/lightning/win32/mozconfig 	1.6
mozilla/uriloader/exthandler/win/nsOSHelperAppService.cpp 	1.85
mozilla/uriloader/exthandler/win/nsOSHelperAppService.h 	1.33
mozilla/suite/shell/src/nsWindowsShellService.cpp 	1.4
mozilla/tools/tinderbox-configs/sunbird/win32/mozconfig 	1.36
mozilla/configure.in 	1.1987
Status: NEW → RESOLVED
Last Resolved: 10 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Whiteboard: [licensing issue see bug 397678 comment 44][has patch][has approval] → [licensing issue see bug 397678 comment 44]
Target Milestone: --- → Firefox 3
Comment on attachment 317117 [details] [diff] [review]
sdk update v.4

>Index: mail/components/shell/nsMailWinIntegration.cpp
>===================================================================
>RCS file: /cvsroot/mozilla/mail/components/shell/nsMailWinIntegration.cpp,v
>retrieving revision 1.9
>diff -u -p -8 -r1.9 nsMailWinIntegration.cpp
>--- mail/components/shell/nsMailWinIntegration.cpp	11 Jul 2007 05:59:57 -0000	1.9
>+++ mail/components/shell/nsMailWinIntegration.cpp	22 Apr 2008 22:37:59 -0000
>@@ -638,64 +644,20 @@ nsWindowsShellService::setKeysForSetting
>   HRESULT hr = CoCreateInstance (CLSID_ApplicationAssociationReg,
>                                  NULL,
>                                  CLSCTX_INPROC,
>                                  IID_IApplicationAssociationReg,
>                                  (void**)&pAAR);

The 2 |*ApplicationAssociationReg| must be renamed here too !
Created attachment 317742 [details] [diff] [review]
followup

mozilla/mail/components/shell/nsMailWinIntegration.cpp 	1.11
(Assignee)

Comment 12

10 years ago
Crap, sorry. search and replace let me down. 
(Assignee)

Comment 13

10 years ago
If anyone on this has delete access to cvs, could you please remove - 

uriloader/exthandler/win/IApplicationAssociationRegistration.h  

(In reply to comment #13)
> If anyone on this has delete access to cvs, could you please remove - 
> uriloader/exthandler/win/IApplicationAssociationRegistration.h  

Done.
You need to log in before you can comment on or make changes to this bug.