429092 - Borders are missing for Task List in Today Pane and Task Mode

Status: RESOLVED FIXED

(Calendar :: Calendar Frontend, defect)

Description

[Christian Jansen]

Attachment: mock-up with border, and margins

The borders are missing for Task List in Today Pane and Task Mode.
see attachment.

Comment 1

[Simon Paquet [:sipaq]]

--> me

Comment 2

[Simon Paquet [:sipaq]]

Moving back to nobody. I didn't get this to work the way I intended.

Comment 3

[Simon Paquet [:sipaq]]

Attachment: Patch

Christian, your mockup looks exactly the same as the output of my patch. So I'll refrain from adding another screenshot.

Comment 4

[Berend Cornelius]

Comment on attachment 322261 [details] [diff] [review]
Patch

I am afraid to say that I am not really content with the result under Linux majorly because of the bad alignment of the textbox "unifinder-task-edit-field" and the tree. I experimented a bit and will post a patch as a new proposal. What improved the situation most is to abandon the "task-quick-add-box" that  seems to be superflouous from my point of view. I admit that with my SunRay at home I have a lousy depiction of the colors, so I will probably have to look at it again when I am in the office.

Comment 5

[Stefan Sitter [:ssitter]]

Please also check how this looks in Sunbird.

Comment 6

[Berend Cornelius]

Attachment: patch as a proposal

Maybe the patch attached that is based on the first patch improves the situation a bit. I haven't tested it under Windows.

Comment 7

[Simon Paquet [:sipaq]]

Berend, I tested your patch on WinXP in Lightning and Sunbird and it looks and works fine in both apps.

However, your patch misses the additional styling changes

  - Removal of .task-quickadd-box style rule
  - addition of #unifinder-task-edit-field style rule
  - change of #unifinder-todo-tree > .calendar-task-tree style rule

in Pinstripe (Mac theme). Can you please add them there as well. Then the patch is ready for review.

Comment 8

[Berend Cornelius]

Attachment: [checked in] patch v. #3

In reply to comment #7:
I did not mean to deliver a reviewable patch but merely wanted to give some hints where I could see room for improvement. Attached you find another patch with the according changes also made for pinstripe. Maybe Daniel can review this for the Mac-platform and also do the ui-review. Under Sunbird it looks the same as under lightning.

Comment 9

[Daniel Boelzle [:dbo]]

Comment on attachment 322508 [details] [diff] [review]
[checked in] patch v. #3

The border doesn't work on Mac, there's no difference. Let's wait for Christian how it should look like.

Comment 10

[Christian Jansen]

Comment on attachment 322508 [details] [diff] [review]
[checked in] patch v. #3

We should fix the Mac problem in a follow-up bug. UI+ = Christian (for Windows only)

Comment 11

[Christian Jansen]

I forgot to ask if it would be possible to add the missing borders, around the task list tree, of the Task Mode. It would be great if we can do this in this bug.

Comment 12

[Berend Cornelius]

patch v. #3 checked in on trunk and MOZILLA_1_8_BRANCH

issue remains open

Comment 13

[Martin Schröder [:mschroeder]]

Remaining issues (according to comment in this bug report):
* Border around task list in Today Pane does not work on MacOS
* Missing borders around task list tree in Task mode

Is this still valid?

Comment 14

[Decathlon]

Attachment: patch for task description area border in task view

This patch adds a border for task description area in task view.
It merely changes the border from 0 to 1px, but I think it looks a bit different from others elements in Lightning like agenda and task list in todaypane.

The following screenshot shows the look of the task description area with the patch (1st screenshot) and how it would look with minimal changes to make the border similar to that one of agenda in today-pane (2nd) and message-pane in main window of Thunderbird with a top-border and without margins (3rd).
I can post the others patches if it needs.

For pinstripe theme I applied the same changes of winstripe one, but I can't verify the effect.

Comment 15

[Decathlon]

Attachment: screenshot: patch for task description area with others two solutions

first image is the previous patch.

Comment 16

[Martin Schröder [:mschroeder]]

Comment on attachment 397256 [details]
screenshot: patch for task description area with others two solutions

I would prefer solution 2, but maybe it's better to ask Bryan what should be implemented.

Comment 17

[Bryan Clark (DevTools PM) [:clarkbw]]

Comment on attachment 397256 [details]
screenshot: patch for task description area with others two solutions

I would go with fix2 as the other borders stand out a bit too much.  My next choice was fix3 as removing the margin allows for more space for content however I think the lesser border and familiarity with the today pane is worth it.

Comment 18

[Martin Schröder [:mschroeder]]

Comment on attachment 397255 [details] [diff] [review]
patch for task description area border in task view

Decathlon, can you please add a patch for solution 2?

Comment 19

[Decathlon]

Attachment: patch-v2 for task description area

(In reply to comment #18)
> (From update of attachment 397255 [details] [diff] [review])
> Decathlon, can you please add a patch for solution 2?

As usual, pinstripe part needs to be verified on a mac.

Comment 20

[Decathlon]

Attachment: borders in task list in task view and unifinder

This patch adds a border for task list tree in task view and event list tree for unifinder that is without that border too.

A pair of questions remain open (apart from problem on Mac):
1. the bottom border of task list in today pane: should it remain without border or not?
2. (minor) the unifinder presents a top border slightly different from that one of task view. Since unifinder is not always visible, should both borders be equal?

In the following screenshot the issue 1. and 2.

Comment 21

[Decathlon]

Attachment: screenshot for issues 1 and 2 in comment 20

Forgot to say that in the previous patch, pinstripe part is a copy of winstripe part because I can't test it on a Mac.

Comment 22

[Philipp Kewisch [:Fallen][☁️📆]]

(In reply to comment #20)
> A pair of questions remain open (apart from problem on Mac):
> 1. the bottom border of task list in today pane: should it remain without
> border or not?
I prefer without border

> 2. (minor) the unifinder presents a top border slightly different from that one
> of task view. Since unifinder is not always visible, should both borders be
> equal?
Yes, I prefer the 3d border from the unifinder.


Can you post a screenshot with a less blue theme?

Comment 23

[Martin Schröder [:mschroeder]]

Comment on attachment 398597 [details] [diff] [review]
patch-v2 for task description area

r=mschroeder. Patch looks good! On Mac, it looks like an editable textfield when focused, but this is okay. I hope it will get editable in the future. :)

Comment 24

[Martin Schröder [:mschroeder]]

(In reply to comment #20)
> Created an attachment (id=421126) [details]
[...]
> A pair of questions remain open (apart from problem on Mac):

The result of this patch looks good on Mac. No need to do further work there in this bug.

Comment 25

[Martin Schröder [:mschroeder]]

Comment on attachment 421126 [details] [diff] [review]
borders in task list in task view and unifinder

r=mschroeder. Let's go with this patch. Philipp's answers to your questions seem to be already included in the last version, correct?

Comment 26

[Decathlon]

(In reply to comment #25)
> (From update of attachment 421126 [details] [diff] [review])
> r=mschroeder. Let's go with this patch. Philipp's answers to your questions
> seem to be already included in the last version, correct?

No, Martin. For the patch 421126 I have to change the top border with a 3d one for the task view and have to post a screenshot as well.

Comment 27

[Philipp Kewisch [:Fallen][☁️📆]]

I think these are minor issues, lets check in this patch and take care of the remaining issues in a followup bug. Decathlon, could you file this bug?

Comment 28

[Philipp Kewisch [:Fallen][☁️📆]]

Pushed to comm-central <http://hg.mozilla.org/comm-central/rev/90e2061a1de8>
-> FIXED

Comment 29

[Philipp Kewisch [:Fallen][☁️📆]]

Pushed to comm-central <http://hg.mozilla.org/comm-central/rev/3c3b7b8b9ff6>
-> FIXED

Comment 30

[Decathlon]

Philipp, I'm testing the patch for borders in task view and it doesn't work as expected with 
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.3a4pre) Gecko/20100326 Lightning/1.1a1pre Shredder/3.2a1pre.
(a black border appears all around the task tree).
Could you confirm?

Instead it works with Thunderbird 3.1 (Lanikai).

To make it working with TB 3.2, it should be changed the position of the line "border: 1px solid;" in the file calendar-task-view.css:

 #calendar-task-tree {
     min-height: 98px;
+    border: 1px solid;
     -moz-border-left-colors: ThreeDShadow ThreeDDarkShadow;
     -moz-border-bottom-colors: ThreeDHighlight ThreeDLightShadow;
     -moz-border-right-colors: ThreeDHighlight ThreeDLightShadow;
-    border-left: 1px solid;
-    border-right: 1px solid;
-    border-bottom: 1px solid;
+    -moz-border-top-colors: ThreeDShadow ThreeDDarkShadow;
 }

Do we add this modify in the followup bug?

Comment 31

[Philipp Kewisch [:Fallen][☁️📆]]

I'd vote for a separate bug. Decathlon, does your solution work for both 3.1 and 3.2?

Comment 32

[Decathlon]

Attachment: patch -v3 (adjust top right corner)

(In reply to comment #31)
> I'd vote for a separate bug. Decathlon, does your solution work for both 3.1
> and 3.2?

Yes it does, but it seems useless because with the latest automatic update of Thunderbird 3.2, the border now is working as expected (no more black border around the task tree):

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.3a5pre) Gecko/20100408 Lightning/1.1a1pre Shredder/3.2a1pre

nevertheless, I want to post the patch because it also changes the *top right corner* to make it equal to the unifinder and mail messages tree as showed in the following screenshot (I didn't see it before, sorry).
The patch adds a bottom border to the box above the task tree instead of the top border to the task tree.

If you think it's not an issue that worth the effort, please discard the patch without problems :-).

Comment 33

[Decathlon]

Attachment: Screenshot: top right corner

Comment 34

[Philipp Kewisch [:Fallen][☁️📆]]

Comment on attachment 438056 [details] [diff] [review]
patch -v3 (adjust top right corner)

>+    border-left: 1px solid;
>+    border-bottom: 1px solid;
>+    border-right: 1px solid;
>     -moz-border-left-colors: ThreeDShadow ThreeDDarkShadow;
>     -moz-border-bottom-colors: ThreeDHighlight ThreeDLightShadow;
>     -moz-border-right-colors: ThreeDHighlight ThreeDLightShadow;

Regarding -moz-border-*-colors: "When an element has a border that is larger than a single CSS pixel, each line of pixels uses the next color specified in this property, from the outside in.".

If we have a 1px border here, there is no sense in specifying two colors. We either needs more border, or less colors.

Comment 35

[Decathlon]

Attachment: patch -v4 (adjust top right corner and delete unnecessary colors)

(In reply to comment #34)

> If we have a 1px border here, there is no sense in specifying two colors. We
> either needs more border, or less colors.

OK, so, there was an error in the original file too. I've deleted the unnecessary border colors. I've tested it on Lanikai and Shredder.

About the black border that appears on Thunderbird 3.2 (see comment #30), I've just tested with the last build (Gecko/20100419) and it has appeared again. This patch fix this issue on TB 3.2 and works fine on Lanikai as well.

Comment 36

[Philipp Kewisch [:Fallen][☁️📆]]

Comment on attachment 440207 [details] [diff] [review]
 patch -v4 (adjust top right corner and delete unnecessary colors)

>+    border-left: 1px solid;
>+    border-bottom: 1px solid;
>+    border-right: 1px solid;
>+    -moz-border-left-colors: ;
>+    -moz-border-bottom-colors: ThreeDHighlight;
>+    -moz-border-right-colors: ThreeDHighlight;

I'm going to shorten this, á la:

   border-left: 1px solid ThreeDShadow;

r=philipp

Comment 37

[Philipp Kewisch [:Fallen][☁️📆]]

Pushed to comm-central <http://hg.mozilla.org/comm-central/rev/280ab12c0542>
-> FIXED