429211 - Using history back/forward keyboard shortcuts doesn't work when using non US keyboard layout

Status: RESOLVED DUPLICATE of bug 306585

(Core :: DOM: UI Events & Focus Handling, defect)

Description

[weweritz]

User-Agent:       Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9pre) Gecko/2008041404 Minefield/3.0pre
Build Identifier: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9pre) Gecko/2008041404 Minefield/3.0pre

When using a keyboard layout that requires pressing another modifier key to get to the [ or ] characters (for example CMD+ALT+F, where ALT+F produces the [ character, thus reproducing the CMD+[ command) I get a strange behavior: the history -> forward keyboard shortcut doesn't work at all. History -> back shortcut redirects me to "http://www.google.com/firefox" - which I presume is the default firefox homepage, though I have it set to "about:blank". 
It redirects me to this page even if there is no tab history present.
Clicking the commands in the history menu produces the desired result.

In the nightly builds from around 4.4.08 the bug was not present, it appeared later, when it automatically upgraded (when manually downgrading, the bug was not present - save for redirecting to google.com/firefox when no tab history is present). 

Reproducible: Always

Steps to Reproduce:
1. change OS keyboard layout to one that requires pressing additional modifier key to produce the [ and ] character
2. use keyboard shortcut with the additional modifier key

Actual Results:  
Back/forward keyboard shortcuts don't work properly - forward doesn't work at all, back redirects to google.com/firefox/

Expected Results:  
should go back/forward, if history present

I tried remapping the keyboard shortcuts in osx leopard's system preferences -> keyboard & mouse -> keyboard shortcuts -> applications -> firefox, but with no luck, whenever i used a shortcut with an additional modifier key it produced the prescribed results.

Comment 1

[:Gijs (he/him)]

My hunch is this would be related to bug 359638. Setting blocking. Please undo if this was in error.

Comment 2

[Serge Gautherie (:sgautherie)]

(In reply to comment #0)
> Build Identifier: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US;
> rv:1.9pre) Gecko/2008041404 Minefield/3.0pre

Bug 359638 was checked in at "2008-04-14 21:16".

(In reply to comment #1)
> My hunch is this would be related to bug 359638. Setting blocking.

Lunik,
which build are you seeing the bug with ? Before, after, both ?

Comment 3

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

I don't understand. '[' and ']' are need option key on US keyboard layout???

You customized the keyboard layout to such layout??

Comment 4

[weweritz]

(In reply to comment #2)
> Lunik,
> which build are you seeing the bug with ? Before, after, both ?
> 

I upgraded from ff3beta5 to nightly 2008040404 on 5.apr, everything was working as expected at that time. 
I believe the browser upgraded automatically to 2008040704, thats when the thing broke. I tried downgrading to 2008040504 nightly, everything worked as expected, except when executing the go back keyboard shortcut when no history is present it redirected to google.com/firefox (for example when opening a new tab and trying to go to previous page in history). I've been using that build till it automatically upgraded to 2008041404 and broke down again.

(In reply to comment #3)
> I don't understand. '[' and ']' are need option key on US keyboard layout???
> 
> You customized the keyboard layout to such layout??
> 

Um, the US keyboard has separate keys for '[' and ']' characters, no additional modifiers are required, correct? 
For moving back and forward in history you have to press cmd+[ or cmd+]

Im using a Slovenian keyboard layout, for producing '[' and ']' characters I have to press alt+f / alt+g (i cant get to [ or ] characters without pressing any modifiers), therefore i have to press 'cmd+alt+f' or 'g' shortcuts to go back or forward. If I switch to US keyboard and use the keys where '[' or ']' characters are located on US layout, it works ok. If I try remapping the keyboard shortucts in the OS to anything else than cmd+[, it works the way as described before.

Comment 5

[Karl Tomlinson (:karlt)]

This is similar to bug 306585.
(but in bug 306585 Cmd-Shift-8 wouldn't be bound to findOnCmd).

Comment 6

[Karl Tomlinson (:karlt)]

(In reply to comment #5)
> (but in bug 306585 Cmd-Shift-8 wouldn't be bound to findOnCmd).

Cmd-Option-8 I mean

Comment 7

[weweritz]

(In reply to comment #5)
> This is similar to bug 306585.
> (but in bug 306585 Cmd-Shift-8 wouldn't be bound to findOnCmd).
> 

Indeed it is. 
In build 2008041504 the behaviour has changed slightly, cmd+option+f (back) no longer redirects to google.com/firefox and behaves as descibed in bug 306585.

Comment 8

[Tony Mechelynck [:tonymec]]

Hm. I use Alt+Left for Back and Alt+Right for Forward (didn't know about Ctrl+bracket). Is this a Mac/Linux difference or are both shortcuts valid on both systems?

However this might be related to a bug which is in the process of being fixed ATM... I'd say one or more of bug 359638, bug 414130, bug 399939 and maybe others linked from these. I think that bug 359638 is the most important of them but I may be wrong. (And BTW I notice that it is "blocked" by this one and also mentioned in comment #2.)

Comment 9

[Tony Mechelynck [:tonymec]]

P.S. Maybe also bug 429219.

Comment 10

[Karl Tomlinson (:karlt)]

(In reply to comment #8)
> Hm. I use Alt+Left for Back and Alt+Right for Forward (didn't know about
> Ctrl+bracket). Is this a Mac/Linux difference or are both shortcuts valid on
> both systems?

Cmd+[ works on Mac and Ctrl+[ on Linux.
Option+Left doesn't seem to work on Mac.  (I don't know if it ever did.)

Comment 11

[Henrik Skupin [:whimboo][⌚️UTC+1]]

(In reply to comment #8)
> Hm. I use Alt+Left for Back and Alt+Right for Forward (didn't know about
> Ctrl+bracket). Is this a Mac/Linux difference or are both shortcuts valid on
> both systems?

Tony, your mentioned shortcuts don't work if the cursor is within a text field. AFAIK there are the brackets which even work in such a case. I'm not really sure because for a German keyboard layout it's a hassle to reach them and I don't use them.

Comment 12

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

er, ok. This is dup of bug 306585.