429293 - [zh-CN] add en.wikipedia.org to Simplified Chinese

Status: RESOLVED FIXED

(Mozilla Localizations :: zh-CN / Chinese (Simplified), defect)

Description

[Axel Hecht [:Pike]]

As wikipedia isn't blocked in China anymore, we should add it to the build.

Please be careful with the naming of the plugin, it should be wikipedia-zh-CN.xml, to not conflict with bug 425053.

We need a plugin for that. You should create this by following what we do
for en-US closely, that one is at
http://mxr.mozilla.org/mozilla/source/browser/locales/en-US/searchplugins/wikipedia.xml.
Use that as a template, and change the Urls accordingly, and use the link title
of the rel="search" link on your wikipedia site as ShortName. That matches what
the site sends, so Firefox will detect that it already has the search plugin.
So, now you have the plugin in zh-CN/browser/searchplugins/wikipedia-zh-CN.xml, and to get it picked up, you add wikipedia-zh-CN in list.txt.

To create the patch, do, in browser/searchplugins
cvs add wikipedia-zh-CN.xml
cvs -z3 diff -uN

and attach the output here, and mark it as patch, there's a checkbox for that.
To request review on that, set the "Review" flag to '?', and the requestee to
my bugzilla ID.

Comment 1

[Jack Guo]

We are going to use english version wikipedia in firefox-zh-CN, entrance shall be the same as above (en-US).

The Chinese version wikipedia (http://zh.wikipedia.org/wiki/) is still blocked, because it is in Taiwan. 

Thanks,
Jack

Comment 2

[Shaohua Wen]

Attachment: patch to add en-US WIKIpedia

Comment 3

[Axel Hecht [:Pike]]

Comment on attachment 316207 [details] [diff] [review]
patch to add en-US WIKIpedia

We should use a separate plugin for en.wikipedia.org for zh-CN, I suggest copying over the en-US plugin over to a new file zh-CN/browser/searchplugins/wikipedia-en-CN.xml, and to reference that.

Comment 4

[Mic Berman]

sounds good to me especially in case government may change their mind so we could easily remove. thanks pike

Comment 5

[Shaohua Wen]

The government might change their mind (ONLY) after taiwan re-united...
The english wikipedia site could be blocked at any day when some VIP was not happy with it...
Just joking.

Comment 6

[Mic Berman]

;-)

Comment 7

[Shaohua Wen]

Attachment: add zh-CN wikipedia

Comment 8

[Axel Hecht [:Pike]]

Comment on attachment 316426 [details] [diff] [review]
add zh-CN wikipedia

r-, the plugin is English (en), not Chinese (zh). It should be named wikipedia-en-CN.xml

Comment 9

[Shaohua Wen]

Attachment: wikipedia-en-CN

Comment 10

[Axel Hecht [:Pike]]

Comment on attachment 316594 [details] [diff] [review]
wikipedia-en-CN

r,a=me, please land this patch asap, with a comment referencing this bug and my review/approval.

Comment 11

[Shaohua Wen]

Checking in list.txt;
/l10n/l10n/zh-CN/browser/searchplugins/list.txt,v  <--  list.txt
new revision: 1.13; previous revision: 1.12
done
RCS file: /l10n/l10n/zh-CN/browser/searchplugins/wikipedia-en-CN.xml,v
done
Checking in wikipedia-en-CN.xml;
/l10n/l10n/zh-CN/browser/searchplugins/wikipedia-en-CN.xml,v  <--  wikipedia-en-CN.xml
initial revision: 1.1
done

Comment 12

[Axel Hecht [:Pike]]

Please mark your bugs FIXED after check-in, doing so based on the looking at the source.

This could use some verification.

Comment 13

[Axel Hecht [:Pike]]

http://hg.mozilla.org/users/axel_mozilla.com/l10n-src-verification/index.cgi/file/c23c169cb2a0/reference/HEAD/zh-CN/ is the updated src reference.