Closed
Bug 429388
Opened 18 years ago
Closed 18 years ago
vfychain.main leaks memory
Categories
(NSS :: Libraries, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
3.12
People
(Reporter: alvolkov.bgs, Assigned: alvolkov.bgs)
Details
Attachments
(1 file)
|
1.22 KB,
patch
|
nelson
:
review+
|
Details | Diff | Splinter Review |
Function main leaks memory allocated to keep data for certDir, progName, oidStr, revConfig and password.
Attachment #316100 -
Flags: review?(nelson)
|
||
Comment 1•18 years ago
|
||
Comment on attachment 316100 [details] [diff] [review]
Use PORT_Free to deallocate the memory.
>+ if (progName)
>+ PORT_Free(progName);
>+ if (certDir)
>+ PORT_Free(certDir);
>+ if (oidStr)
>+ PORT_Free(oidStr);
>+ if (revConfig)
>+ PORT_Free(revConfig);
>+ if (password)
>+ PORT_Free(password);
PORT_Free checks its argument for NULL, making the checks added above
redundant. I'd prefer not to have those redundant checks.
|
|
||
Comment 2•18 years ago
|
||
Comment on attachment 316100 [details] [diff] [review]
Use PORT_Free to deallocate the memory.
r+ once the redundant checks are removed.
Attachment #316100 -
Flags: review?(nelson) → review+
|
|
Assignee | |
Comment 3•18 years ago
|
||
Patch is integrated.
Status: NEW → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•