429396 - Crash when quitting app. [@ PR_Lock - nsHashtable::Put - nsMenuBarX::RegisterForContentChanges]

Status: RESOLVED WORKSFORME

(Core :: Widget: Cocoa, defect)

Description

[Simon Howes]

User-Agent:       Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9pre) Gecko/2008041604 Minefield/3.0pre
Build Identifier: 

Sometimes when quitting app crash reporter loads.

http://crash-stats.mozilla.com/report/list?range_unit=months&query_search=signature&query_type=contains&signature=PR_Lock&query=PR_Lock&range_value=1

Reproducible: Sometimes

Comment 1

[timeless]

I was going to have you pick a stack trace and an exception reason, as a quick psuedo random sampling yields the following distinct crashes. instead I've picked one for you and I'll ask someone else to find/file bugs for the rest

Signature	PR_Lock - js_GetStringBytes
bp-2a4bee35-0c3b-11dd-86e2-001cc45a2c28
Crash Reason	EXC_BAD_ACCESS / KERN_PROTECTION_FAILURE
Crash Address	0x4bcea
Uptime	41

spidermonkey, contributing cause: jsd (venkman/firebug).
assi: igor
cc: ted because of probable lying Uptime field

Signature	PR_Lock - PR_EnterMonitor / nsComponentManagerImpl::GetService
bp-9a8969a8-0c34-11dd-8366-001cc45a2ce4
Crash Reason	EXCEPTION_STACK_OVERFLOW
Crash Address	0x60015e72
Uptime	0 [startup]

xpcom, contributing cause: docshell
cc: jst, bz

Signature	PR_Lock - nsHashtable::Put - nsMenuBarX::RegisterForContentChanges
bp-b19b1738-0ba4-11dd-848e-0013211cbf8a
Crash Reason	EXC_BAD_ACCESS / KERN_PROTECTION_FAILURE
Crash Address	0x4bcea
Comments	Quit app.

cocoa
cc: josh

Signature	PR_Lock - nsThread::Dispatch
bp-8532bfab-0ad4-11dd-bafc-001321b13766
Uptime	205
Crash Reason	EXCEPTION_PRIV_INSTRUCTION
Crash Address	0x600cb272

xpcom, 
contributing cause: shutdown [this is thread 1. main thread should be 0, but there are no other threads, esp. not a main thread]
cc: darin, dougt

foreign files:
Filename 	Version 	Debug Identifier 	Debug Filename
LVPrcInj.dll 	11.5.0.1158 	9DC29ACA17A34C89B9612E686B60990D1 	LVPrcInj.pdb

Signature	PR_Lock - FreeArenaList
bp-9abe3fb8-0a2d-11dd-853f-001cc4e2bf68
Uptime	349
Crash Reason	EXCEPTION_PRIV_INSTRUCTION
Crash Address	0x600cb281

layout, contributing cause views
cc: roc

Comment 2

[Steven Michaud [:smichaud] (Retired)]

I bet this is related to bug 429215.  I'm going to post a patch for that bug shortly.

Comment 3

[timeless]

yeah, i was trying to remember where that bug was, i knew i had seen it (and i think i even remember trying and failing to fix the summary)

Bug 429215 – Crash while closing the Amazing Media Browser Window direct after Startup [@ PR_Lock - nsHashtable::Put - nsMenuBarX::RegisterForContentChanges][@ prmmap.c:52] 

to whomever verifies this bug, *please* be sure there are bug numbers for the other crashers from comment 1 identified in later comments in this bug, I'd hate to lose the research i did.

the only one i can easily spot is:
Bug 425266 - Crash [@ JS_GetFunctionName][@ PR_Lock - js_GetStringBytes] starting venkman

Bug 411492 is about nsThreadManager but I don't think it's very related to the nsThread crash here (I'm not going to check now).

so there are 3 other crashes that need bugs :(

Comment 4

[Steven Michaud [:smichaud] (Retired)]

> Bug 429215 – Crash while closing the Amazing Media Browser Window
> direct after Startup [@ PR_Lock - nsHashtable::Put -
> nsMenuBarX::RegisterForContentChanges][@ prmmap.c:52]

Actually, this is probably bug 426499 (and therefore probably fixed by
my patch for that bug).  This crash looks exactly like ones I saw
playing with the Help menu while quitting with a lot of tabs loaded
into a single browser window.

Sorry for the confusion.

Comment 5

[Jesse Ruderman]

http://crash-stats.mozilla.com/ says there have been no Mac crashes during the last week with any of these 3 signatures.  There were Windows crashes for the first two, but unrelated to menus and infrequent.

WFM, likely fixed by one of the bugs Steven mentioned.