429417 - Breadcrumbs error on forums

Status: RESOLVED INCOMPLETE

(Websites Graveyard :: spreadfirefox.com, defect, P1)

Description

[Alex Polvi]

When you visit:

  http://www.spreadfirefox.com/forum/168

The breadcrumb is: "Home :: Forums :: Community @ SFx"

When you click the thread "Firefox Live Support"

  http://www.spreadfirefox.com/node/539

The breadcrumb jumps to: "Home :: Projects :: Community @ SFx :: Forums :: Community @ SFx :: General Discussion"

This is incorrect, and should read: "Home :: Forums :: Community @ SFx :: General Discussion"

Comment 1

[Chris Pollett]

Here is what caused the problem:
(1) You created a new discussion topic
(2) You selected the same value for both the forums and
the groups :: audience.

The default value for (2) is unselected, but once you have 
selected Community @ SFx it is somewhat hard to unselect.
The net result is it appends both to the bread crumb. 
My recommendation is to recreate the topic without the group::audience
selected.

Comment 2

[krupa raj[:krupa]]

I am able to reproduce this bug on staging with a valid workflow:

Workflow:
1.User is a member of a project
2.User visits the group forum
3.User clicks on one of the existing forums-general discussion topics.

steps to reproduce:
1.Go to https://spreadfirefox.authstage.mozilla.com
2.Login with valid credentials
3.Click on a group you are member of.eg:100% organic campaigns
4.In the group homepage,click on group forums.
5.Notice the breadcrumb at this point.Breadcrumb is->  Home >Forums
6.Click on one of the available general discussion topics in the group forums
7.Notice the breadcrumb now.The breadcrumb is Home >Projects >100% organic campaigns >Forums 100% organic campaigns > General Discussion

So I am reopening this bug.

Comment 3

[Alex Buchanan [:abuchanan]]

Another case of broken forums breadcrumbs I wanted to document...

while logged out...

1) go to node/2639.  Notice the sidebar shows this post as part of the "Firefox 3" project

2) In the breadcrumb, click "General Discussion".  You'll get Access Denied, but notice the sidebar now says "Community @ SFx"
  - access should be granted
  - sidebar should be in the "Firefox 3" context

3) go back to node/2639

4) In the breadcrumb, click "Forums".  
  - breadcrumbs disappear, they shouldn't
  - "General Discussion" parent forum is, "Firefox in Hrvatska (Croatia)", should be "Firefox 3"

I see also, that this is repeatable on other nodes, I tried 1027 and 2612

Paul, maybe this is related to bug 481689 and OG_forum?

Comment 4

[Paul Booker]

(In reply to comment #2)
> I am able to reproduce this bug on staging with a valid workflow:
> 
> Workflow:
> 1.User is a member of a project
> 2.User visits the group forum
> 3.User clicks on one of the existing forums-general discussion topics.
> 
> steps to reproduce:
> 1.Go to https://spreadfirefox.authstage.mozilla.com
> 2.Login with valid credentials
> 3.Click on a group you are member of.eg:100% organic campaigns
> 4.In the group homepage,click on group forums.
> 5.Notice the breadcrumb at this point.Breadcrumb is->  Home >Forums
> 6.Click on one of the available general discussion topics in the group forums
> 7.Notice the breadcrumb now.The breadcrumb is Home >Projects >100% organic
> campaigns >Forums 100% organic campaigns > General Discussion
> 
> So I am reopening this bug.

I'll see what i can do here.  

A few notes ..

The breadcrumb below are created by the forum module ..
    * Home > Forums > Community @ SFx 

The breadcrumb here are created by the OG forum module ..
    * Home > Projects > Community @ SFx > Forums > Community @ SFx > General Discussion

Comment 5

[Paul Booker]

(In reply to comment #3)
> Another case of broken forums breadcrumbs I wanted to document...
> 
> while logged out...
> 
> 1) go to node/2639.  Notice the sidebar shows this post as part of the "Firefox
> 3" project
> 
> 2) In the breadcrumb, click "General Discussion".  You'll get Access Denied,
> but notice the sidebar now says "Community @ SFx"
>   - access should be granted
>   - sidebar should be in the "Firefox 3" context
> 
> 3) go back to node/2639
> 
> 4) In the breadcrumb, click "Forums".  
>   - breadcrumbs disappear, they shouldn't
>   - "General Discussion" parent forum is, "Firefox in Hrvatska (Croatia)",
> should be "Firefox 3"
> 
> I see also, that this is repeatable on other nodes, I tried 1027 and 2612
> 
> Paul, maybe this is related to bug 481689 and OG_forum?


These are quite serious problem , ill look into these now and get them fixed

Comment 6

[Paul Booker]

It looks as though this problem is a consequence of a problem that used to exist in OG Forum where you could post a group forum post into one of your group forums and also select any of the groups that your subscribed too. This was not correct as the group you post into is implied when your post is posted into a particular group forum. 

Currently you can't generate this problem with new posts so the problem to be fixed looks to one of deleting records in the og_ancestory table. 

If you look at the og_ancestory table for nid = 2639 you will see two records one for group with nid = 799 (firefox) and nid = 499 (Community @ SFX).

I'll see if i can engineer the problem on my local server now and propose a solution later this evening ...

Best, Paul

Comment 7

[Paul Booker]

So to fix this we need to run a small script which goes through the og_ancestory table and deletes each node that is a group affiliated forum post which is incorrectly associated with a group other than the forum group.

I'll need to get a copy of the database to test my script on
my local spreadfirefox server

Best, Paul

Comment 8

[Paul Booker]

There are about 500 forum nodes which have multiple records in the og_ancestory table where they should have only one. 

So the problem that Alex reported in #3 occurs with 500 nodes on our site.
The site therefore is broken until this is fixed and so i think we should change the milestone back to 3.0 and fix this before we launch. I'll provide an SQL later today that will correct this problem.

#forum nodes that have been posted in to multiple groups
SELECT oa.nid, COUNT( * ) AS forum_nodes_posted_into_multiple_groups
FROM og_ancestry AS oa, node AS n
WHERE oa.nid = n.nid
AND n.type = 'forum'
GROUP BY oa.nid
HAVING forum_nodes_posted_into_multiple_groups > 1
ORDER BY oa.nid DESC


Best, Paul

Comment 9

[Paul Booker]

Here's is my Pseudo program

LOOP around distinct forum node "nid" entries in the table og_ancestory.
  Use the table forum to find the vocabulary term "tid" for this forum node  
  Use the table og_term to find the single group node "nid"
  DELETE all og_ancestory records where the "group_nid" is not the above "nid"
  REPEAT  

I'll write a script for this now .....

Comment 10

[Paul Booker]

Here is the code that i ran against my spreadfirefox database and it worked as expected clearing out the erroneous records in the og_ancestry table. Can we backup this table and run this script on stage. I have modularized the code, ill attach shortly.

$result = db_query("SELECT DISTINCT oa.nid AS nid, COUNT(*) AS forum_nodes_posted_into_multiple_groups FROM og_ancestry AS oa, node AS n WHERE oa.nid = n.nid AND n.type = 'forum' GROUP BY oa.nid HAVING forum_nodes_posted_into_multiple_groups > 1");
  while ($row = db_fetch_object($result)) {
    $nid = $row->nid;
	$tid = db_result(db_query("SELECT tid FROM forum WHERE nid = %d", $nid));
	$group_nid = db_result(db_query("SELECT nid FROM og_term WHERE tid = %d", $tid));
	db_query("DELETE FROM og_ancestry WHERE nid = %d AND group_nid != %d", $nid, $group_nid);
  }

Comment 11

[Paul Booker]

Attachment: Delete erroneous records in the og_ancestry table

Comment 12

[Paul Booker]

The module needs to be installed and the cron then needs to run to execute the script.

Best, Paul

Comment 13

[Alex Buchanan [:abuchanan]]

Paul, I think it's probably better if you assign to [e-mail] instead of assigning to Mary in the future, because Mary can't really do much for this one and it helps keep the bugs organized

Thanks!

Comment 14

[Paul Booker]

@Alex  Will do

Just wanted to say that a number of breadcrumb related problems were fixed in OG FORUM @ D6 over the past year that have not been backported to D5

Best, 
Paul Booker
Appcoast