429529 - Do not calculate page ranks every time /tiki-wiki_rankings.php is loaded

Status: RESOLVED FIXED

(support.mozilla.org :: General, defect)

Description

[Laura Thomson :laura]

This page is linked from the homepage.  The pagerank calculation queries are bringing the database to its knees.

Comment 1

[Laura Thomson :laura]

Attachment: Turn off recalculation.

We'll also need a cron job to calculate these periodically.

Comment 2

[Laura Thomson :laura]

Committed patch in r12362.

Comment 3

[Laura Thomson :laura]

Pushed.

Comment 4

[Louis-Philippe Huberdeau]

Removing the function call solves the performance problem, but this one cannot be upstreamed directly.

It's quite a nasty function however and really does not deserve to be called every time.

I see three options:
* Run it as part of editpage. Because ranking is based on links, it should not vary any more than that. However, I saw quite a few problems with that page being too slow already.
* Run it on demand, but set a timeout on it so it only runs like once an hour (configurable).
* Let it run from cron. This cannot be the only option for the other installations.

Any input?

Comment 5

[David Tenser [:djst]]

James or morgamic: any input on the best approach here?

Comment 6

[James Socol [:jsocol, :james]]

tiki-editpage.php already times out, so the first option should be avoided if at all possible.
The cron option works well for us--but do we really use this feature?--with the on-demand option being the most universal.

Comment 7

[Paul Craciunoiu [:paulc]]

I suggest creating an admin panel for perf preferences, having those off by default. In turn, SUMO would turn them on. One of those prefs would cause the piece of code in question here to not be executed, while the admin option would make sure to mention "Note: enabling this breaks this functionality"

Comment 8

[James Socol [:jsocol, :james]]

Paul's solution works, but there needs to be a mechanism to trigger the calculation. Either an on-demand option, the cron, or perhaps something like a random integer, 1-1000 and if you roll a 1, calculate the ranks.

Comment 9

[Louis-Philippe Huberdeau]

Used the dice roll approach. Limit can be changed using a preference. Using 1000 by default.