429547 - Support aria-activedescendant usage in nsIAccesible::TakeFocus()

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[Aaron Leventhal]

Currently we only handle #1 below. We need to implement part 2.

1. If the current element can take real DOM focus, set the DOM focus to it.
2. Otherwise, if the current element has and ID an ancestor with a the aria-activedescendant attribute present, then set DOM focus to that ancestor. If successful, then set aria-activedescendant on the ancestor to the ID of the desired element.

Comment 1

[alexander :surkov (:asurkov)]

Attachment: patch

Comment 2

[Aaron Leventhal]

Surkov, do you think that |if (!frame->IsFocusable)| and we don't satisfy all the aria-activedescendant conditions, that we should exit early?

Otherwise looks good.

Comment 3

[Aaron Leventhal]

Comment on attachment 316645 [details] [diff] [review]
patch

Either way, r+, because the focus attempt should fail anyway. It just might be nice to make sure to fail in those cases.

Comment 4

[alexander :surkov (:asurkov)]

(In reply to comment #2)
> Surkov, do you think that |if (!frame->IsFocusable)| and we don't satisfy all
> the aria-activedescendant conditions, that we should exit early?
> 
> Otherwise looks good.
> 

Probably that makes sense but I tried to do minimum changes to avoid possible regressions (I keep in mind the case when different accessibles with different frames shares the same DOM node). But if you like I'll change this.

Comment 5

[Aaron Leventhal]

True, it is sensible to make the most minimal change.

Comment 6

[Damon Sicore (:damons)]

Possible to add a test here?  Re-request approval once addressed.

Comment 7

[alexander :surkov (:asurkov)]

Comment on attachment 316645 [details] [diff] [review]
patch

(In reply to comment #6)
> Possible to add a test here?  Re-request approval once addressed.
> 

mochitest with the patch.

re-requesting approval.

Comment 8

[Damon Sicore (:damons)]

Comment on attachment 316645 [details] [diff] [review]
patch

a1.9+=damons

Comment 9

[alexander :surkov (:asurkov)]

Checking in accessible/src/base/nsAccessible.cpp;
/cvsroot/mozilla/accessible/src/base/nsAccessible.cpp,v  <--  nsAccessible.cpp
new revision: 1.376; previous revision: 1.375
done
Checking in accessible/tests/mochitest/Makefile.in;
/cvsroot/mozilla/accessible/tests/mochitest/Makefile.in,v  <--  Makefile.in
new revision: 1.15; previous revision: 1.14
done
RCS file: /cvsroot/mozilla/accessible/tests/mochitest/test_aria_activedescendant.html,v
done
Checking in accessible/tests/mochitest/test_aria_activedescendant.html;
/cvsroot/mozilla/accessible/tests/mochitest/test_aria_activedescendant.html,v  <--  test_aria_activedescendant.html
initial revision: 1.1
done