429622 - Crash [@ nsRootAccessible::GetState(unsigned int*, unsigned int*) ]

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[Marco Zehe (:MarcoZ)]

Found while triaging crash stats. Happens with beta 5.
http://crash-stats.mozilla.com/report/list?range_unit=weeks&query_search=signature&query_type=contains&product=Firefox&platform=windows%2Cmac%2Clinux&version=Firefox%3A3.0b5%2CFirefox%3A3.0pre&branch=1.9&signature=nsRootAccessible%3A%3AGetState(unsigned+int*%2C+unsigned+int*)&query=Access&range_value=1

Looks like we're using a focusController without checking if it is not NULL first. Will submit a patch soon.

Comment 1

[Marco Zehe (:MarcoZ)]

Attachment: Simple NULL check

Comment 2

[Aaron Leventhal]

Comment on attachment 316385 [details] [diff] [review]
Simple NULL check

How can it happen that there is no focus controller? That seems like a possible bad regression outside of a11y.

Comment 3

[Aaron Leventhal]

Comment on attachment 316385 [details] [diff] [review]
Simple NULL check

It's a safe "wallpaper fix"

Comment 4

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 316385 [details] [diff] [review]
Simple NULL check

a1.9=beltzner

Comment 5

[Damon Sicore (:damons)]

Wouldn't hold the release, but seems fixed anyway.

Comment 6

[Marco Zehe (:MarcoZ)]

Checking in accessible/src/base/nsRootAccessible.cpp;
/cvsroot/mozilla/accessible/src/base/nsRootAccessible.cpp,v  <--  nsRootAccessible.cpp
new revision: 1.268; previous revision: 1.267
done