Closed Bug 429642 Opened 12 years ago Closed 9 years ago

Crash [@ nsAccessibleWrap::get_accKeyboardShortcut(tagVARIANT, unsigned short**) ]

Categories

(Core :: Disability Access APIs, defect)

x86
Windows XP
defect
Not set
critical

Tracking

()

RESOLVED FIXED
mozilla7

People

(Reporter: MarcoZ, Assigned: tbsaunde)

References

Details

(Keywords: access, crash)

Crash Data

Attachments

(1 file, 1 obsolete file)

Again, not a significant number of crashes to block.  Marco, do we have any idea of how many beta testers are using accessibility?

Flags: blocking1.9? → blocking1.9-
(In reply to comment #1)
> Again, not a significant number of crashes to block.  Marco, do we have any
> idea of how many beta testers are using accessibility?

Unfortunately not. This one, along with some of the others, looks like someone was experimenting with calling our APIs and giving us wrong parameters, and we're not protecting properly against those cases. Alexander Surkov filed bug 429990 to deal with all these in one big sweep, but I am not sure we want to try and take this for 1.9 or wait until Firefox 3 ships.
Mass un-assigning bugs assigned to Aaron.
Assignee: aaronleventhal → nobody
Target Milestone: mozilla1.9 → ---
I get essentially the same stack from Visual C++, although the nsTArray frame is not there. Either the stack is corrupted, or some memory is corrupted and we're calling something we shouldn't be.
Crash Signature: [@ nsAccessibleWrap::get_accKeyboardShortcut(tagVARIANT, unsigned short**) ]
Attached patch patch (obsolete) — Splinter Review
I think we want these checks any way and hopefully it'll fix the crashes.
Attachment #541899 - Flags: review?(surkov.alexander)
Comment on attachment 541899 [details] [diff] [review]
patch

Review of attachment 541899 [details] [diff] [review]:
-----------------------------------------------------------------

r=me since the patch makes sense

::: accessible/src/msaa/nsAccessibleWrap.cpp
@@ +494,5 @@
>  
> +  nsAutoString shortcut;
> +  nsresult rv = xpAccessible->GetKeyboardShortcut(shortcut);
> +  if (NS_FAILED(rv))
> +    return E_FAIL;

return GetHRESULT(rv);
Attachment #541899 - Flags: review?(surkov.alexander) → review+
Assignee: nobody → trev.saunders
Attached patch patchSplinter Review
fix return value
Attachment #541899 - Attachment is obsolete: true
landed http://hg.mozilla.org/mozilla-central/rev/1d351cc0e8c1
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla7
You need to log in before you can comment on or make changes to this bug.