429650 - Crash [@ CAccessibleText::get_attributes(long, long*, long*, unsigned short**) ]

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[Marco Zehe (:MarcoZ)]

Found while triaging 3.0b5 crashers. One crash report:
bp-d181faf5-0a01-11dd-9b1f-001cc4e2bf68

Comment 1

[Damon Sicore (:damons)]

Not a significant number to block on.  Please re-nom if you disagree.

Comment 2

[alexander :surkov (:asurkov)]

Attachment: looks like?

Comment 3

[Marco Zehe (:MarcoZ)]

Alexander, do we have more places where we could harden our code against invalid arguments? I've seen a couple more crashes with only single instances which appeared to look like this one.

Comment 4

[alexander :surkov (:asurkov)]

All places are our ;) If we would ensure it's incorrect client's call then we could fix it but even MSDN gives examples where they do not check this.

Comment 5

[alexander :surkov (:asurkov)]

Marco, I filed bug 429990 to address your comment.

Comment 6

[Damon Sicore (:damons)]

Comment on attachment 316543 [details] [diff] [review]
looks like?

Tests?  Explanation of risk?  Re-request approval once addressed.

Comment 7

[alexander :surkov (:asurkov)]

Comment on attachment 316543 [details] [diff] [review]
looks like?

(In reply to comment #6)
> (From update of attachment 316543 [details] [diff] [review])
> Tests?  Explanation of risk?  Re-request approval once addressed.
> 

No risk - it's just out argument checkin on NULL. It should hard to get a test, at least I can't keep in mind the way how to achieve this. Basically we should write external c++ application which should operate with firefox (small IAccessible2 client). I think it's not reasonable to spend significant amount of time for such small and simple patch.

re-requesting approval

Comment 8

[Damon Sicore (:damons)]

Comment on attachment 316543 [details] [diff] [review]
looks like?

a1.9+=damons

Comment 9

[alexander :surkov (:asurkov)]

Checking in accessible/src/msaa/CAccessibleText.cpp;
/cvsroot/mozilla/accessible/src/msaa/CAccessibleText.cpp,v  <--  CAccessibleText.cpp
new revision: 1.12; previous revision: 1.11
done