Closed Bug 429650 Opened 12 years ago Closed 12 years ago

Crash [@ CAccessibleText::get_attributes(long, long*, long*, unsigned short**) ]

Categories

(Core :: Disability Access APIs, defect, major)

x86
Windows XP
defect
Not set
major

Tracking

()

RESOLVED FIXED
mozilla1.9

People

(Reporter: MarcoZ, Assigned: surkov)

References

Details

(Keywords: access, crash)

Crash Data

Attachments

(1 file)

Found while triaging 3.0b5 crashers. One crash report:
bp-d181faf5-0a01-11dd-9b1f-001cc4e2bf68
Flags: blocking1.9?
Not a significant number to block on.  Please re-nom if you disagree.
Flags: blocking1.9? → blocking1.9-
Attached patch looks like?Splinter Review
Attachment #316543 - Flags: review?(aaronleventhal)
Alexander, do we have more places where we could harden our code against invalid arguments? I've seen a couple more crashes with only single instances which appeared to look like this one.
All places are our ;) If we would ensure it's incorrect client's call then we could fix it but even MSDN gives examples where they do not check this.
Attachment #316543 - Flags: review?(aaronleventhal)
Attachment #316543 - Flags: review+
Attachment #316543 - Flags: approval1.9?
Marco, I filed bug 429990 to address your comment.
Comment on attachment 316543 [details] [diff] [review]
looks like?

Tests?  Explanation of risk?  Re-request approval once addressed.
Attachment #316543 - Flags: approval1.9? → approval1.9-
Comment on attachment 316543 [details] [diff] [review]
looks like?

(In reply to comment #6)
> (From update of attachment 316543 [details] [diff] [review])
> Tests?  Explanation of risk?  Re-request approval once addressed.
> 

No risk - it's just out argument checkin on NULL. It should hard to get a test, at least I can't keep in mind the way how to achieve this. Basically we should write external c++ application which should operate with firefox (small IAccessible2 client). I think it's not reasonable to spend significant amount of time for such small and simple patch.

re-requesting approval
Attachment #316543 - Flags: approval1.9- → approval1.9?
Comment on attachment 316543 [details] [diff] [review]
looks like?

a1.9+=damons
Attachment #316543 - Flags: approval1.9? → approval1.9+
Checking in accessible/src/msaa/CAccessibleText.cpp;
/cvsroot/mozilla/accessible/src/msaa/CAccessibleText.cpp,v  <--  CAccessibleText.cpp
new revision: 1.12; previous revision: 1.11
done

Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Crash Signature: [@ CAccessibleText::get_attributes(long, long*, long*, unsigned short**) ]
You need to log in before you can comment on or make changes to this bug.