429667 - make EnableTextbox() available in all prefpanes

Status: RESOLVED FIXED

(SeaMonkey :: Preferences, defect)

Description

[Bruno 'Aqualon' Escherl]

EnableTextbox(aTextboxId, aValue, aFocus) can be used in all prefpanes, where a checkbox is used to enable/disable a textbox, so it's useful to have it available everywhere and don't have redundant code.

Comment 1

[Bruno 'Aqualon' Escherl]

Attachment: patch v1

Adds a new preferences.js and loads its content into preferences.xul.

Comment 2

[Karsten Düsterloh]

Comment on attachment 316423 [details] [diff] [review]
patch v1

Some uncalled for nits: ;-)

>Index: suite/common/pref/preferences.js
>===================================================================
>+// The contents of this file will be loaded into the scope of the
>+// prefwindow and is available in all prefpanes!

"content ... be available to ..."
But IanN and Neil should know even better. ;-)

>+function EnableTextbox(aTextboxId, aValue, aFocus)

I'd rename aValue to aCheckboxValue to make its use more clear.

>+  let enable = aValue && !pref.locked;

I'd use "enabled", because it's a state.

>Index: suite/common/pref/preferences.xul
>===================================================================
>   <stringbundle id="bundle_prefutilities"
>                 src="chrome://communicator/locale/pref/prefutilities.properties"/>
> 
>+  <script type="application/x-javascript" src="chrome://communicator/content/pref/preferences.js"/>
>+

The <script> should be the first child.

Comment 3

[Ian Neal]

Comment on attachment 316423 [details] [diff] [review]
patch v1

r=me with mnyromyr's nits fixed

Comment 4

[[e-mail]]

Comment on attachment 316423 [details] [diff] [review]
patch v1

I don't quite agree with Mnyromyr!

>+// The contents of this file will be loaded into the scope of the
>+// prefwindow and is available in all prefpanes!
I'd swap things so you get "is loaded" and "will be available".

>+function EnableTextbox(aTextboxId, aValue, aFocus)
I'd call it aEnable rather than aCheckbox.

Comment 5

[Bruno 'Aqualon' Escherl]

Attachment: patch v2

Patch, addressing the review comments (I took Neil's suggestions).

Comment 6

[Karsten Düsterloh]

Landed v2 on trunk.

Comment 7

[Bruno 'Aqualon' Escherl]

Thx for landing -> RESOLVED FIXED