429668 - Remove the column picker control from the Library window

Status: VERIFIED FIXED

(Firefox :: Bookmarks & History, defect)

Description

[Alex Faaborg [:faaborg] (Firefox UX)]

The column picker control that appears to the far right of the window is not native to any of the current platforms we ship on, we should remove it from the library window.  Alternate ways of changing the set of available columsn include the view menu and right clicking on any of the column headers.

Comment 1

[Marco Bonardo [:mak]]

so, context menu for column headers has to be fixed since now i don't see column choices there

Comment 2

[Alex Faaborg [:faaborg] (Firefox UX)]

>so, context menu for column headers has to be fixed since now i don't see
>column choices there

Yeah, my mistake on that.  Really just the view menu should be enough if we don't get around to fixing the context menus on the column headers.

Comment 3

[Marco Bonardo [:mak]]

Attachment: patch

like this? we can use the current ViewMenu functions since they work on actual popup target

Comment 4

[Tracy Walker [:tracy]]

Will this be fixed globally so the column picker is the same across the application?  For instance the Page Info > Media window has the same type of column picker.  In my opinion, inconsistency across the application is just as bad as non-native.

Comment 5

[Marco Bonardo [:mak]]

clearly my patch is only for Library...

Comment 6

[Alex Faaborg [:faaborg] (Firefox UX)]

We should go in and remove the column picker from the other interfaces that use it, but first let's just get it out of the most visible interfaces.

Comment 7

[Tracy Walker [:tracy]]

Alex, please file a follow up bug. I'm not even sure of all the places the column picker exists. But yes, the Library is the most visible one.

Comment 8

[Asaf Romano (gone)]

Couldn't  you set the context attribute on the <treecols> element?

Comment 9

[Marco Bonardo [:mak]]

Attachment: patch

yes, for sure

Comment 10

[Asaf Romano (gone)]

Comment on attachment 316479 [details] [diff] [review]
patch

r=mano

Comment 11

[Damon Sicore (:damons)]

Comment on attachment 316479 [details] [diff] [review]
patch

a1.9+=damons

Comment 12

[Dietrich Ayala (:dietrich)]

Checking in browser/components/places/content/places.xul;
/cvsroot/mozilla/browser/components/places/content/places.xul,v  <--  places.xul
new revision: 1.131; previous revision: 1.130
done

Comment 13

[Tracy Walker [:tracy]]

verified with:
Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.4; en-US; rv:1.9pre) Gecko/2008042004 Minefield/3.0pre

Comment 14

[Andrés Delfino]

Follow up bug regarding all column pickers: bug 429925.

Comment 15

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv