Remove the column picker control from the Library window

VERIFIED FIXED

Status

()

Firefox
Bookmarks & History
VERIFIED FIXED
10 years ago
8 years ago

People

(Reporter: faaborg, Assigned: mak)

Tracking

Trunk
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

10 years ago
The column picker control that appears to the far right of the window is not native to any of the current platforms we ship on, we should remove it from the library window.  Alternate ways of changing the set of available columsn include the view menu and right clicking on any of the column headers.
(Assignee)

Comment 1

10 years ago
so, context menu for column headers has to be fixed since now i don't see column choices there
(Reporter)

Comment 2

10 years ago
>so, context menu for column headers has to be fixed since now i don't see
>column choices there

Yeah, my mistake on that.  Really just the view menu should be enough if we don't get around to fixing the context menus on the column headers.
(Assignee)

Comment 3

10 years ago
Created attachment 316437 [details] [diff] [review]
patch

like this? we can use the current ViewMenu functions since they work on actual popup target
Attachment #316437 - Flags: review?(mano)

Comment 4

10 years ago
Will this be fixed globally so the column picker is the same across the application?  For instance the Page Info > Media window has the same type of column picker.  In my opinion, inconsistency across the application is just as bad as non-native.
(Assignee)

Comment 5

10 years ago
clearly my patch is only for Library...
(Reporter)

Comment 6

10 years ago
We should go in and remove the column picker from the other interfaces that use it, but first let's just get it out of the most visible interfaces.

Comment 7

10 years ago
Alex, please file a follow up bug. I'm not even sure of all the places the column picker exists. But yes, the Library is the most visible one.
Couldn't  you set the context attribute on the <treecols> element?
(Assignee)

Comment 9

10 years ago
Created attachment 316479 [details] [diff] [review]
patch

yes, for sure
Attachment #316437 - Attachment is obsolete: true
Attachment #316479 - Flags: review?(mano)
Attachment #316437 - Flags: review?(mano)
(Assignee)

Updated

10 years ago
Assignee: nobody → mak77
Comment on attachment 316479 [details] [diff] [review]
patch

r=mano
Attachment #316479 - Flags: review?(mano) → review+
(Assignee)

Updated

10 years ago
Attachment #316479 - Flags: approval1.9?
Comment on attachment 316479 [details] [diff] [review]
patch

a1.9+=damons
Attachment #316479 - Flags: approval1.9? → approval1.9+
(Assignee)

Updated

10 years ago
Keywords: checkin-needed
Checking in browser/components/places/content/places.xul;
/cvsroot/mozilla/browser/components/places/content/places.xul,v  <--  places.xul
new revision: 1.131; previous revision: 1.130
done
Status: NEW → RESOLVED
Last Resolved: 10 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
verified with:
Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.4; en-US; rv:1.9pre) Gecko/2008042004 Minefield/3.0pre
Status: RESOLVED → VERIFIED

Comment 14

10 years ago
Follow up bug regarding all column pickers: bug 429925.
Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv
Component: Places → Bookmarks & History
QA Contact: places → bookmarks
You need to log in before you can comment on or make changes to this bug.