Closed Bug 429785 Opened 16 years ago Closed 16 years ago

DOMParser reports errors any time it's used from chrome

Categories

(Core :: DOM: Core & HTML, defect)

x86
macOS
defect
Not set
major

Tracking

()

RESOLVED FIXED

People

(Reporter: bzbarsky, Assigned: bzbarsky)

References

Details

(Keywords: regression)

Attachments

(1 file)

This is a regression due to me not noticing that we try to reset the base URI yet again later in the method when fixing bug 421228.  I wish I'd gotten sane tests written for that bug; they should have caught this...

This will confuse extension developers no end, at the very least.

Patch attached, but again tests won't happen until after mid-May.  :(  Yes, that means the patch is not tested.  I'd dearly love some help with that, if at all possible.
Flags: in-testsuite?
Flags: blocking1.9?
Attachment #316530 - Flags: superreview?(jonas)
Attachment #316530 - Flags: review?(jonas)
Marking blocking per Boris' suggestion. 

Jonas, let's get a review ASAP.
Flags: blocking1.9? → blocking1.9+
Comment on attachment 316530 [details] [diff] [review]
This ought to fix it

Looks good to me
Attachment #316530 - Flags: superreview?(jonas)
Attachment #316530 - Flags: superreview+
Attachment #316530 - Flags: review?(jonas)
Attachment #316530 - Flags: review+
Jonas I'm assuming you tested it then?  Anything else we should do before landing?
Comment on attachment 316530 [details] [diff] [review]
This ought to fix it

a1.9+=damons
Attachment #316530 - Flags: approval1.9+
Checked in, with test.
Status: NEW → RESOLVED
Closed: 16 years ago
Flags: in-testsuite? → in-testsuite+
Resolution: --- → FIXED
Component: DOM: Mozilla Extensions → DOM
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.