Closed
Bug 429785
Opened 17 years ago
Closed 17 years ago
DOMParser reports errors any time it's used from chrome
Categories
(Core :: DOM: Core & HTML, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: bzbarsky, Assigned: bzbarsky)
References
Details
(Keywords: regression)
Attachments
(1 file)
|
3.01 KB,
patch
|
sicking
:
review+
sicking
:
superreview+
damons
:
approval1.9+
|
Details | Diff | Splinter Review |
This is a regression due to me not noticing that we try to reset the base URI yet again later in the method when fixing bug 421228. I wish I'd gotten sane tests written for that bug; they should have caught this...
This will confuse extension developers no end, at the very least.
Patch attached, but again tests won't happen until after mid-May. :( Yes, that means the patch is not tested. I'd dearly love some help with that, if at all possible.
Flags: in-testsuite?
Flags: blocking1.9?
Attachment #316530 -
Flags: superreview?(jonas)
Attachment #316530 -
Flags: review?(jonas)
|
||
Comment 1•17 years ago
|
||
Marking blocking per Boris' suggestion.
Jonas, let's get a review ASAP.
Flags: blocking1.9? → blocking1.9+
Comment on attachment 316530 [details] [diff] [review]
This ought to fix it
Looks good to me
Attachment #316530 -
Flags: superreview?(jonas)
Attachment #316530 -
Flags: superreview+
Attachment #316530 -
Flags: review?(jonas)
Attachment #316530 -
Flags: review+
|
||
Comment 3•17 years ago
|
||
Jonas I'm assuming you tested it then? Anything else we should do before landing?
|
|
||
Comment 4•17 years ago
|
||
Comment on attachment 316530 [details] [diff] [review]
This ought to fix it
a1.9+=damons
Attachment #316530 -
Flags: approval1.9+
|
Assignee | |
Comment 5•17 years ago
|
||
Checked in, with test.
Status: NEW → RESOLVED
Closed: 17 years ago
Flags: in-testsuite? → in-testsuite+
Resolution: --- → FIXED
|
||
Updated•12 years ago
|
Component: DOM: Mozilla Extensions → DOM
|
|
||
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•