Closed Bug 429821 Opened 17 years ago Closed 16 years ago

Port |Bug 422700 – Get bug 376238 fixed or disable images on drag feedback| to SeaMonkey

Categories

(SeaMonkey :: MailNews: Message Display, defect)

Product:
SeaMonkey
Component:
MailNews: Message Display
Platform:
x86
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
seamonkey2.0a1

People

(Reporter: sgautherie, Assigned: sgautherie)

References

Details

(Keywords: dogfood)

Attachments

(2 files, 1 obsolete file)

(Av1) <mailnews.js> whitespace cleanup [Checkin: Comment 10]
26.39 KB, patch
Bienvenu
: review+
Bienvenu
: superreview+
Details | Diff | Splinter Review
(Bv1) <mailnews.js> Add new preference [Checkin: Comment 9]
1.58 KB, patch
Bienvenu
: review+
Bienvenu
: superreview+
Details | Diff | Splinter Review 
Per bug 360488 dependency.
Blocks: TB2SM
Assignee: mail → sgautherie.bz
Status: NEW → ASSIGNED

    
    

    
  


  
*Converts tabs to spaces.
*Removes spaces at end of lines.
*Add spaces between preference names and values.

Use Av1-Bw to ease review.

        Attachment #316585 -
        Flags: superreview?(bienvenu)

        Attachment #316585 -
        Flags: review?(bienvenu)

    
    

    
  


  
It seems this file is still used/shared by Thunderbird:
<http://mxr.mozilla.org/mozilla/search?string=mailnews.js>
At least, it's packaged in
[Mozilla Thunderbird, version 3.0a1pre (2008032702)] (nightly) (W2Ksp4)

Then, should I (re)move the preference from <all-thunderbird.js> ? (see bug 422700)
Or add an |#ifdef MOZ_SUITE| here ?

        Attachment #316587 -
        Flags: superreview?(bienvenu)

        Attachment #316587 -
        Flags: review?(bienvenu)

    
    

    
  
Comment on attachment 316585 [details] [diff] [review]
(Av1) <mailnews.js> whitespace cleanup
[Checkin: Comment 10]

does this patch have anything to do with this bug? I can't see that it does...

    
    

    
  
Comment on attachment 316585 [details] [diff] [review]
(Av1) <mailnews.js> whitespace cleanup
[Checkin: Comment 10]

No, this patch is unrelated to any "bug":
simple cleanup while there.

    
    

    
  
Comment on attachment 316585 [details] [diff] [review]
(Av1) <mailnews.js> whitespace cleanup
[Checkin: Comment 10]

ok, thx

        Attachment #316585 -
        Flags: superreview?(bienvenu)

        Attachment #316585 -
        Flags: superreview+

        Attachment #316585 -
        Flags: review?(bienvenu)

        Attachment #316585 -
        Flags: review+

    
  
Keywords: checkin-needed
Whiteboard: [c-n: Av1 // Leave opened]

    
  

        Attachment #316587 -
        Flags: superreview?(bienvenu)

        Attachment #316587 -
        Flags: superreview+

        Attachment #316587 -
        Flags: review?(bienvenu)

        Attachment #316587 -
        Flags: review+

    
    

    
  
David, what about my questions in comment 3 ?

    
    

    
  
better to remove it from all-thunderbird.js, I think, thx.

    
  
Whiteboard: [c-n: Av1 // Leave opened] → [c-n: Av1, Bv1 // Leave opened]

    
    

    
  
Comment on attachment 316587 [details] [diff] [review]
(Bv1) <mailnews.js> Add new preference
[Checkin: Comment 9]

Checking in mailnews/mailnews.js;
/cvsroot/mozilla/mailnews/mailnews.js,v  <--  mailnews.js
new revision: 3.312; previous revision: 3.311
done

        Attachment #316587 -
        Attachment filename: 429821-Bv1_mailnews.js.patch → [checked in] 429821-Bv1_mailnews.js.patch

    
    

    
  
Comment on attachment 316585 [details] [diff] [review]
(Av1) <mailnews.js> whitespace cleanup
[Checkin: Comment 10]

Checking in mailnews/mailnews.js;
/cvsroot/mozilla/mailnews/mailnews.js,v  <--  mailnews.js
new revision: 3.313; previous revision: 3.312
done

        Attachment #316585 -
        Attachment filename: 429821-Av1_mailnews.js.patch → [checked in] 429821-Av1_mailnews.js.patch

    
  

        Attachment #316587 -
        Attachment description: (Bv1) <mailnews.js> Add new preference → (Bv1) <mailnews.js> Add new preference
[Checkin: Comment 9]

        Attachment #316587 -
        Attachment filename: [checked in] 429821-Bv1_mailnews.js.patch → 429821-Bv1_mailnews.js.patch

    
  

        Attachment #316585 -
        Attachment description: (Av1) <mailnews.js> whitespace cleanup → (Av1) <mailnews.js> whitespace cleanup
[Checkin: Comment 10]

        Attachment #316585 -
        Attachment filename: [checked in] 429821-Av1_mailnews.js.patch → 429821-Av1_mailnews.js.patch

    
  

        Attachment #316584 -
        Attachment is obsolete: true

    
  
Blocks: 422700
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
No longer depends on: 422700
Resolution: --- → FIXED
Whiteboard: [c-n: Av1, Bv1 // Leave opened]

    
  
No longer blocks: TB2SM

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: