429821 - Port |Bug 422700 – Get bug 376238 fixed or disable images on drag feedback| to SeaMonkey

Status: RESOLVED FIXED

(SeaMonkey :: MailNews: Message Display, defect)

Description

[Serge Gautherie (:sgautherie)]

Per bug 360488 dependency.

Comment 1

[Serge Gautherie (:sgautherie)]

Attachment: (Av1-Bw) <mailnews.js> whitespace cleanup

Comment 2

[Serge Gautherie (:sgautherie)]

Attachment: (Av1) <mailnews.js> whitespace cleanup [Checkin: Comment 10]

*Converts tabs to spaces.
*Removes spaces at end of lines.
*Add spaces between preference names and values.

Use Av1-Bw to ease review.

Comment 3

[Serge Gautherie (:sgautherie)]

Attachment: (Bv1) <mailnews.js> Add new preference [Checkin: Comment 9]

It seems this file is still used/shared by Thunderbird:
<http://mxr.mozilla.org/mozilla/search?string=mailnews.js>
At least, it's packaged in
[Mozilla Thunderbird, version 3.0a1pre (2008032702)] (nightly) (W2Ksp4)

Then, should I (re)move the preference from <all-thunderbird.js> ? (see bug 422700)
Or add an |#ifdef MOZ_SUITE| here ?

Comment 4

[David :Bienvenu]

Comment on attachment 316585 [details] [diff] [review]
(Av1) <mailnews.js> whitespace cleanup
[Checkin: Comment 10]

does this patch have anything to do with this bug? I can't see that it does...

Comment 5

[Serge Gautherie (:sgautherie)]

Comment on attachment 316585 [details] [diff] [review]
(Av1) <mailnews.js> whitespace cleanup
[Checkin: Comment 10]

No, this patch is unrelated to any "bug":
simple cleanup while there.

Comment 6

[David :Bienvenu]

Comment on attachment 316585 [details] [diff] [review]
(Av1) <mailnews.js> whitespace cleanup
[Checkin: Comment 10]

ok, thx

Comment 7

[Serge Gautherie (:sgautherie)]

David, what about my questions in comment 3 ?

Comment 8

[David :Bienvenu]

better to remove it from all-thunderbird.js, I think, thx.

Comment 9

[Magnus Melin [:mkmelin]]

Comment on attachment 316587 [details] [diff] [review]
(Bv1) <mailnews.js> Add new preference
[Checkin: Comment 9]

Checking in mailnews/mailnews.js;
/cvsroot/mozilla/mailnews/mailnews.js,v  <--  mailnews.js
new revision: 3.312; previous revision: 3.311
done

Comment 10

[Magnus Melin [:mkmelin]]

Comment on attachment 316585 [details] [diff] [review]
(Av1) <mailnews.js> whitespace cleanup
[Checkin: Comment 10]

Checking in mailnews/mailnews.js;
/cvsroot/mozilla/mailnews/mailnews.js,v  <--  mailnews.js
new revision: 3.313; previous revision: 3.312
done