429841 - build failures in breakpad with 10.5 sdk and --enable-macos-target=10.5

Status: RESOLVED FIXED

(Toolkit :: Crash Reporting, defect)

Description

[Nomis101]

User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X 10_5_2; de-de) AppleWebKit/525.18 (KHTML, like Gecko) Version/3.1.1 Safari/525.18
Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X 10.5; de; rv:1.9pre) Gecko/2008041912 Thunderbird/3.0a1pre ID:2008041912

I'm not able to build Thunderbird 3 by using the 10.5 SDK from Leopard. If I add to my mozconfig "--with-macos-sdk=/Developer/SDKs/MacOSX10.5.sdk" and "--enable-macos-target=10.5" I get the following error:

<<
...
g++-4.0 -arch ppc -o exception_handler.o -c -I../../../../../../../dist/include/system_wrappers -include /temp/mozilla/config/gcc_hidden.h -DOSTYPE=\"Darwin9.2.2\" -DOSARCH=Darwin -I/temp/mozilla/toolkit/crashreporter/google-breakpad/src/client/mac/handler/../../.. -I/temp/mozilla/toolkit/crashreporter/google-breakpad/src/client/mac/handler -I.  -I../../../../../../../dist/include   -I../../../../../../../dist/include/handler -I../../../../../../../dist/include/nspr     -I../../../../../../../dist/sdk/include -I/usr/X11/include   -fPIC  -I/usr/X11/include -fno-rtti -fno-exceptions -Wall -Wconversion -Wpointer-arith -Woverloaded-virtual -Wsynth -Wno-ctor-dtor-privacy -Wno-non-virtual-dtor -Wcast-align -Wno-long-long -isysroot /Developer/SDKs/MacOSX10.5.sdk -fno-strict-aliasing -fpascal-strings -fno-common -fshort-wchar -pthread -I/Developer/SDKs/MacOSX10.5.sdk/Developer/Headers/FlatCarbon  -DNDEBUG -DTRIMMED -O2 -g  -I/usr/X11/include -DMOZILLA_CLIENT -include ../../../../../../../mozilla-config.h -Wp,-MD,.deps/exception_handler.pp /temp/mozilla/toolkit/crashreporter/google-breakpad/src/client/mac/handler/exception_handler.cc
/temp/mozilla/toolkit/crashreporter/google-breakpad/src/client/mac/handler/exception_handler.cc: In member function ‘bool google_breakpad::ExceptionHandler::Teardown()’:
/temp/mozilla/toolkit/crashreporter/google-breakpad/src/client/mac/handler/exception_handler.cc:582: warning: converting to non-pointer type ‘mach_port_t’ from NULL
/temp/mozilla/toolkit/crashreporter/google-breakpad/src/client/mac/handler/minidump_generator.cc: In member function ‘bool google_breakpad::MinidumpGenerator::WriteStack(natural_t*, MDMemoryDescriptor*)’:
/temp/mozilla/toolkit/crashreporter/google-breakpad/src/client/mac/handler/minidump_generator.cc:271: error: ‘struct __darwin_ppc_thread_state’ has no member named ‘r1’
/temp/mozilla/toolkit/crashreporter/google-breakpad/src/client/mac/handler/minidump_generator.cc: In member function ‘u_int64_t google_breakpad::MinidumpGenerator::CurrentPCForStack(natural_t*)’:
/temp/mozilla/toolkit/crashreporter/google-breakpad/src/client/mac/handler/minidump_generator.cc:279: error: ‘struct __darwin_ppc_thread_state’ has no member named ‘srr0’
/temp/mozilla/toolkit/crashreporter/google-breakpad/src/client/mac/handler/minidump_generator.cc: In member function ‘bool google_breakpad::MinidumpGenerator::WriteContext(natural_t*, MDLocationDescriptor*)’:
/temp/mozilla/toolkit/crashreporter/google-breakpad/src/client/mac/handler/minidump_generator.cc:297: error: ‘struct __darwin_ppc_thread_state’ has no member named ‘srr0’
/temp/mozilla/toolkit/crashreporter/google-breakpad/src/client/mac/handler/minidump_generator.cc:298: error: ‘struct __darwin_ppc_thread_state’ has no member named ‘cr’
/temp/mozilla/toolkit/crashreporter/google-breakpad/src/client/mac/handler/minidump_generator.cc:299: error: ‘struct __darwin_ppc_thread_state’ has no member named ‘xer’
/temp/mozilla/toolkit/crashreporter/google-breakpad/src/client/mac/handler/minidump_generator.cc:300: error: ‘struct __darwin_ppc_thread_state’ has no member named ‘ctr’
/temp/mozilla/toolkit/crashreporter/google-breakpad/src/client/mac/handler/minidump_generator.cc:301: error: ‘struct __darwin_ppc_thread_state’ has no member named ‘mq’
/temp/mozilla/toolkit/crashreporter/google-breakpad/src/client/mac/handler/minidump_generator.cc:302: error: ‘struct __darwin_ppc_thread_state’ has no member named ‘lr’
/temp/mozilla/toolkit/crashreporter/google-breakpad/src/client/mac/handler/minidump_generator.cc:303: error: ‘struct __darwin_ppc_thread_state’ has no member named ‘vrsave’
/temp/mozilla/toolkit/crashreporter/google-breakpad/src/client/mac/handler/minidump_generator.cc:305: error: ‘struct __darwin_ppc_thread_state’ has no member named ‘r0’
/temp/mozilla/toolkit/crashreporter/google-breakpad/src/client/mac/handler/minidump_generator.cc:306: error: ‘struct __darwin_ppc_thread_state’ has no member named ‘r1’
/temp/mozilla/toolkit/crashreporter/google-breakpad/src/client/mac/handler/minidump_generator.cc:307: error: ‘struct __darwin_ppc_thread_state’ has no member named ‘r2’
/temp/mozilla/toolkit/crashreporter/google-breakpad/src/client/mac/handler/minidump_generator.cc:308: error: ‘struct __darwin_ppc_thread_state’ has no member named ‘r3’
/temp/mozilla/toolkit/crashreporter/google-breakpad/src/client/mac/handler/minidump_generator.cc:309: error: ‘struct __darwin_ppc_thread_state’ has no member named ‘r4’
/temp/mozilla/toolkit/crashreporter/google-breakpad/src/client/mac/handler/minidump_generator.cc:310: error: ‘struct __darwin_ppc_thread_state’ has no member named ‘r5’
/temp/mozilla/toolkit/crashreporter/google-breakpad/src/client/mac/handler/minidump_generator.cc:311: error: ‘struct __darwin_ppc_thread_state’ has no member named ‘r6’
/temp/mozilla/toolkit/crashreporter/google-breakpad/src/client/mac/handler/minidump_generator.cc:312: error: ‘struct __darwin_ppc_thread_state’ has no member named ‘r7’
/temp/mozilla/toolkit/crashreporter/google-breakpad/src/client/mac/handler/minidump_generator.cc:313: error: ‘struct __darwin_ppc_thread_state’ has no member named ‘r8’
/temp/mozilla/toolkit/crashreporter/google-breakpad/src/client/mac/handler/minidump_generator.cc:314: error: ‘struct __darwin_ppc_thread_state’ has no member named ‘r9’
/temp/mozilla/toolkit/crashreporter/google-breakpad/src/client/mac/handler/minidump_generator.cc:315: error: ‘struct __darwin_ppc_thread_state’ has no member named ‘r10’
/temp/mozilla/toolkit/crashreporter/google-breakpad/src/client/mac/handler/minidump_generator.cc:316: error: ‘struct __darwin_ppc_thread_state’ has no member named ‘r11’
/temp/mozilla/toolkit/crashreporter/google-breakpad/src/client/mac/handler/minidump_generator.cc:317: error: ‘struct __darwin_ppc_thread_state’ has no member named ‘r12’
/temp/mozilla/toolkit/crashreporter/google-breakpad/src/client/mac/handler/minidump_generator.cc:318: error: ‘struct __darwin_ppc_thread_state’ has no member named ‘r13’
/temp/mozilla/toolkit/crashreporter/google-breakpad/src/client/mac/handler/minidump_generator.cc:319: error: ‘struct __darwin_ppc_thread_state’ has no member named ‘r14’
/temp/mozilla/toolkit/crashreporter/google-breakpad/src/client/mac/handler/minidump_generator.cc:320: error: ‘struct __darwin_ppc_thread_state’ has no member named ‘r15’
/temp/mozilla/toolkit/crashreporter/google-breakpad/src/client/mac/handler/minidump_generator.cc:321: error: ‘struct __darwin_ppc_thread_state’ has no member named ‘r16’
/temp/mozilla/toolkit/crashreporter/google-breakpad/src/client/mac/handler/minidump_generator.cc:322: error: ‘struct __darwin_ppc_thread_state’ has no member named ‘r17’
/temp/mozilla/toolkit/crashreporter/google-breakpad/src/client/mac/handler/minidump_generator.cc:323: error: ‘struct __darwin_ppc_thread_state’ has no member named ‘r18’
/temp/mozilla/toolkit/crashreporter/google-breakpad/src/client/mac/handler/minidump_generator.cc:324: error: ‘struct __darwin_ppc_thread_state’ has no member named ‘r19’
/temp/mozilla/toolkit/crashreporter/google-breakpad/src/client/mac/handler/minidump_generator.cc:325: error: ‘struct __darwin_ppc_thread_state’ has no member named ‘r20’
/temp/mozilla/toolkit/crashreporter/google-breakpad/src/client/mac/handler/minidump_generator.cc:326: error: ‘struct __darwin_ppc_thread_state’ has no member named ‘r21’
/temp/mozilla/toolkit/crashreporter/google-breakpad/src/client/mac/handler/minidump_generator.cc:327: error: ‘struct __darwin_ppc_thread_state’ has no member named ‘r22’
/temp/mozilla/toolkit/crashreporter/google-breakpad/src/client/mac/handler/minidump_generator.cc:328: error: ‘struct __darwin_ppc_thread_state’ has no member named ‘r23’
/temp/mozilla/toolkit/crashreporter/google-breakpad/src/client/mac/handler/minidump_generator.cc:329: error: ‘struct __darwin_ppc_thread_state’ has no member named ‘r24’
/temp/mozilla/toolkit/crashreporter/google-breakpad/src/client/mac/handler/minidump_generator.cc:330: error: ‘struct __darwin_ppc_thread_state’ has no member named ‘r25’
/temp/mozilla/toolkit/crashreporter/google-breakpad/src/client/mac/handler/minidump_generator.cc:331: error: ‘struct __darwin_ppc_thread_state’ has no member named ‘r26’
/temp/mozilla/toolkit/crashreporter/google-breakpad/src/client/mac/handler/minidump_generator.cc:332: error: ‘struct __darwin_ppc_thread_state’ has no member named ‘r27’
/temp/mozilla/toolkit/crashreporter/google-breakpad/src/client/mac/handler/minidump_generator.cc:333: error: ‘struct __darwin_ppc_thread_state’ has no member named ‘r28’
/temp/mozilla/toolkit/crashreporter/google-breakpad/src/client/mac/handler/minidump_generator.cc:334: error: ‘struct __darwin_ppc_thread_state’ has no member named ‘r29’
/temp/mozilla/toolkit/crashreporter/google-breakpad/src/client/mac/handler/minidump_generator.cc:335: error: ‘struct __darwin_ppc_thread_state’ has no member named ‘r30’
/temp/mozilla/toolkit/crashreporter/google-breakpad/src/client/mac/handler/minidump_generator.cc:336: error: ‘struct __darwin_ppc_thread_state’ has no member named ‘r31’
/temp/mozilla/toolkit/crashreporter/google-breakpad/src/client/mac/handler/minidump_generator.cc: In member function ‘bool google_breakpad::MinidumpGenerator::WriteModuleListStream(MDRawDirectory*)’:
/temp/mozilla/toolkit/crashreporter/google-breakpad/src/client/mac/handler/minidump_generator.cc:708: warning: ‘_dyld_present’ is deprecated (declared at /Developer/SDKs/MacOSX10.5.sdk/usr/include/mach-o/dyld.h:237)
/temp/mozilla/toolkit/crashreporter/google-breakpad/src/client/mac/handler/minidump_generator.cc:708: warning: ‘_dyld_present’ is deprecated (declared at /Developer/SDKs/MacOSX10.5.sdk/usr/include/mach-o/dyld.h:237)
make[7]: *** [minidump_generator.o] Error 1
make[7]: *** Waiting for unfinished jobs....
make[7]: Leaving directory `/temp/mozilla/obj-powerpc-apple-darwin9.2.2/ppc/toolkit/crashreporter/google-breakpad/src/client/mac/handler'
make[6]: *** [libs] Error 2
make[6]: Leaving directory `/temp/mozilla/obj-powerpc-apple-darwin9.2.2/ppc/toolkit/crashreporter'
make[5]: *** [libs] Error 2
make[5]: Leaving directory `/temp/mozilla/obj-powerpc-apple-darwin9.2.2/ppc/toolkit'
make[4]: *** [libs_tier_toolkit] Error 2
make[4]: Leaving directory `/temp/mozilla/obj-powerpc-apple-darwin9.2.2/ppc'
make[3]: *** [tier_toolkit] Error 2
make[3]: Leaving directory `/temp/mozilla/obj-powerpc-apple-darwin9.2.2/ppc'
make[2]: *** [alldep] Error 2
make[2]: Leaving directory `/temp/mozilla/obj-powerpc-apple-darwin9.2.2/ppc'
make[1]: *** [alldep] Error 2
make[1]: Leaving directory `/temp/mozilla'
make: *** [alldep] Error 2
make: Leaving directory `/temp/mozilla'
Macintosh:mozilla 
>>

I cleaned up my optimize flag (to "-O2 -g") for todays test to avoid conflicts with any weird options. But I get the same error. I use Xcode 3.1 on my PPC (OS X 10.5.2) for this, but I get this message also with XCode 3.0. 

Reproducible: Always

Steps to Reproduce:
1. Add to your mozconfig "--with-macos-sdk=/Developer/SDKs/MacOSX10.5.sdk" and "--enable-macos-target=10.5" 
2. Change the SDK version also in /macosx/universal/mozconfig
3. Build Thunderbird
Actual Results:  
I get the error message shown above


I use Xcode 3.1, PPC, Mac OS X 10.5.2 and gcc version 4.0.1 (Apple Inc. build 5478).

My mozconfig was:

<<
export CC=gcc-4.0 
export CXX=g++-4.0 

# Options for client.mk.
. $topsrcdir/mail/config/mozconfig
. $topsrcdir/build/macosx/universal/mozconfig
mk_add_options MOZ_CO_PROJECT=mail
mk_add_options MOZ_MAKE_FLAGS="-j4"
mk_add_options MOZ_CO_LOCALES=de 
mk_add_options MOZ_OBJDIR=@TOPSRCDIR@/obj-@CONFIG_GUESS@

# Options for 'configure' (same as command-line options).
ac_add_options --with-macos-sdk=/Developer/SDKs/MacOSX10.5.sdk
ac_add_options --enable-macos-target=10.5
ac_add_options --enable-application=mail
ac_add_options --enable-static
ac_add_options --enable-static-libs 
ac_add_options --enable-static-mail
ac_add_options --enable-crypto
ac_add_options --enable-update-packaging
ac_add_options --enable-update-channel=nightly
ac_add_options --enable-ldap
ac_add_options --enable-ui-locale=de 
ac_add_options --enable-optimize="--O2 -g" 
ac_add_options --disable-shared
ac_add_options --disable-debug
ac_add_options --disable-dtd-debug 
ac_add_options --disable-tests
>>

Comment 1

[Nomis101]

I have additional informations. Compiling with the 10.5 SDK works if I don't use "--enable-macos-target=10.5". Trying to build Thunderbird with "--with-macos-sdk=/Developer/SDKs/MacOSX10.5.sdk" AND "--enable-macos-target=10.5" doesn't work. Trying to build Thunderbird only with "--with-macos-sdk=/Developer/SDKs/MacOSX10.5.sdk" works perfect.

Comment 2

[Mark Banner (:standard8)]

This looks like a crash reporter problem, moving to more relevant component.

Comment 3

[(not currently active) Ted Mielczarek]

I can build Firefox just fine with the 10.5 SDK, although I'm not sure if I used --enable-macos-target=10.5. What happens if you drop that line (or change it to 10.4?) Your build will still run on 10.5 just fine.

Comment 4

[Nomis101]

I can build Thunderbird just fine with the 10.5 SDK if I don't use the --enable-macos-target=10.5. It also builds fine with the 10.5 SDK if I use --enable-macos-target=10.4. So I think the problem isn't the 10.5 SDK but rather the --enable-macos-target=10.5. Therefore I think a better description of my problem would be "Can't build Thunderbird 3 by using macos-target=10.5"

Comment 6

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Confirming based on the dupe.

FWIW, this is on file at breakpad as http://code.google.com/p/google-breakpad/issues/detail?id=248

Comment 7

[Nomis101]

Nice to know. In this link it is mentioned that the MacOSX10.5.sdk cause this error, but in my case it is only "--enable-macos-target=10.5".
At the moment I avoid this error by adding "--disable-crashreporter" to my mozconfig.
Tomorrow I will try this patch from the link.

Comment 8

[Nomis101]

Attachment: patch from the link in Comment #6, adapted for mozilla-central

Now I've tried the patch from the link in Comment #6. This patch works for me. Without this patch I get the error and with this patch I get a successful build.
So I've adapted this patch for mozilla-central and added it to this bug.
But keep in mind, this is my first patch and I don't know really what this patch is doing. I only copied the patch from the link in Comment #6 and adapted it for mozilla-central. But I checked it twice and it worked for me.

Comment 9

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Looks like breakpad r328 includes a fix for this: http://code.google.com/p/google-breakpad/source/detail?r=328 (but not the same fix that was in issue 248).

Comment 10

[(not currently active) Ted Mielczarek]

Fixed by bug 510920.