429867 - [10.3][10.4] New find bar should be dismissable with Command-.

Status: RESOLVED WONTFIX

(Camino Graveyard :: General, defect)

Description

[Lance Boyle]

User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en; rv:1.8.1.14) Gecko/20080409 Camino/1.6 (like Firefox/2.0.0.14)
Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en; rv:1.8.1.14) Gecko/20080409 Camino/1.6 (like Firefox/2.0.0.14)

The new find bar that appears at the bottom of the page when pressing Command-F should be able to be dismissed by hitting Command-. , when it has focus. Having to click on the little x is just way too much work. It makes my back hurt.

Reproducible: Always

Steps to Reproduce:
1.
2.
3.

Comment 1

[Samuel Sidler (old account; do not CC)]

Escape works as a keyboard command, but cmd-. makes sense too. I think this makes sense and can't think of a reason not to do it. Confirming.

Comment 2

[Stuart Morgan]

Attachment: fix [landed on trunk & branch]

Odd; esc and Command-. send different commands.

Comment 3

[Mike Pinkerton (not reading bugmail)]

Comment on attachment 316639 [details] [diff] [review]
fix [landed on trunk & branch]

sr=pink

Comment 4

[Stuart Morgan]

Landed on trunk.

Comment 5

[Samuel Sidler (old account; do not CC)]

Worth taking in 1.6.1?

Comment 6

[Eiichi]

I tested 2008-04-22-01 trunk build, Command-. still doesn't work on OS X 10.4.

Comment 7

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Eiichi, I just noticed your comment today; if a bug appears not to be fixed, reopening it is a better way to make sure it gets noticed. :)

I tested this on 10.3.9 in preparation for approving it for the branch, and Cmd-. doesn't work there, either.  With some logging, it seems like Cmd-. doesn't send any selector on 10.3.9, and it's possible that this is the problem on 10.4, too.

After talking with Stuart, the plan here is to land the patch as-is for 1.6.1, thus fixing this bug on 10.5, and reopen this bug as a 10.3/10.4 bug for fixing it completely (either with pKE: or mento's magic view or some other as-yet-unknown method; it should be fixable).  And also to fix the method's comment ;)

Comment 8

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

I checked this in for 1.6.1.

Comment 9

[Gordon P. Hemsley [:GPHemsley]]

This bug has been buried in the graveyard and has not been updated in over 5 years. It is probably safe to assume that it will never be fixed, so resolving as WONTFIX.

[Mass-change filter: graveyard-wontfix-2014-09-24]