429898 - Zooming up with keyboard is broken for a Russian keyboard layout

Status: RESOLVED FIXED

(Core :: DOM: UI Events & Focus Handling, defect)

Description

[Roman R.]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9pre) Gecko/2008041907 Minefield/3.0pre
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9pre) Gecko/2008041907 Minefield/3.0pre

Ctrl++ (zoom up) doesn't work since bug 429180 got fixed. I use a layout that's different from one that's shipped with Windows. Some people call it phonetic (most Cyrillic keys coincide, more or less, with English letters). I don't know how else to describe it other than by attaching a screen shot with all keys displayed (if I can find a way to do this). However, I want to add that keyboard layouts can be modified to fit one's needs, other people use similar layouts but not identical, and Firefox (or any other program) should be able to deal with this. This problem didn't exists before bug 429180 got fixed, and this means that it's possible. Other hotkeys are processed correctly, e.g. Ctrl-c, Ctrl-v, Ctrl+t, Ctrl+w, and Ctrl++ should too.

Reproducible: Always

Comment 1

[Roman R.]

To be consistent: Ctrl+c, Ctrl+v (pluses instead of minuses).

Comment 2

[Markus Stange [:mstange]]

(In reply to comment #0)
> how else to describe it other than by attaching a screen shot with all keys
> displayed (if I can find a way to do this).

Maybe it's possible using the Microsoft Keyboard Layout Creator:
http://www.microsoft.com/globaldev/tools/msklc.mspx

Comment 3

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

This is too strange bug. Because I only added an alternative charCode when the current keyboard layout cannot input Alphabets/Numeric directly.

I have three questions:

1. Can you use Ctrl++ on Fx2?
2. Can you use other all commands on current trunk?
3. How to set the your keyboard layout on my system? How did you set up such non-standard keyboard layout?

Comment 4

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Are you using this keyboard layout??
http://www.methodius.org/rus.html

But it looks like the layout doesn't have '+' key... It should not work fine even if the patch of bug 429180 is not landed...

Comment 5

[Roman R.]

Markus, thank you -- it worked.

Masayuki, answering your questions:

1. Can you use Ctrl++ on Fx2?

Yes, I can.

2. Can you use other all commands on current trunk?

As I said in my initial comment here, other hotkeys are processed correctly, e.g.
Ctrl+c, Ctrl+v, Ctrl+t, Ctrl+w. Does this answer your question or do you mean some other commands?

3. How to set the your keyboard layout on my system? How did you set up such
non-standard keyboard layout?

I used a keyboard layout tool to create a DLL file that implemented the layout and replaced a DLL that came with Windows with mine.

A word of caution: it would be a mistake to find a workaround only for my particular layout because anyone with a tool can create a new one, and things worked well before the the patch of bug 429180 or that for a bug it refers to has landed.

Comment 6

[Roman R.]

Attachment: Russian keyboard layout I use

Comment 7

[Markus Stange [:mstange]]

Where is the + key in that layout? I can't find it.
What keys do you press when trying to zoom in?

Comment 8

[Roman R.]

Attachment: English layout of the same physical keyboard

Comment 9

[Roman R.]

Marcus, I've always pressed Ctrl and '-' to zoom out and Ctrl and '=' to zoom in. I've never had to actually send '+' (as in Ctrl+Shift+=). Not in Firefox or IE.

Comment 10

[Roman R.]

You know, there are keys on my keyboard (it's a laptop) pressing which with the fn key being pressed produces '+' and '-'. And in a combination with Ctrl, I am able to zoom in and out with the Russian layout being active. However, I really prefer what I was able to do before the mentioned patch(es): to press Ctrl and the key the sends '=' in English layout.

Comment 11

[Karl Tomlinson (:karlt)]

Ctrl-= with the = next to Shift in your layout should work too?

Comment 12

[Roman R.]

Pressing Shift doesn't help. And, I wouldn't want to have to press Shift. Things were good before: Ctrl + one of the keys located one next to another.

Comment 13

[Karl Tomlinson (:karlt)]

(In reply to comment #12)
> Pressing Shift doesn't help. And, I wouldn't want to have to press Shift.
> Things were good before: Ctrl + one of the keys located one next to another.

I'm assuming this was in reply to my comment.

I was pointing out that there is an = on your layout (between . and Shift) and Ctrl+= is bound to zoom up.

It might have been fortunate for you that the key you wanted to zoom up did just that, but we have to trust the keyboard layout to some extent.  IMO if the keyboard layout is set up to put + on a different key, then that seems like an indication that the author didn't want the usual key to produce a "+".

What combination of keys normally enters a "+" character with this layout?
What happens when Ctrl is added to that key combination?

Comment 14

[icez network]

i can't use ctrl+= (zoom in), ctrl+- (zoom out) with thai (ketmanee) keyboard layout too.
but all other keys are working fine now.

* note that ctrl+(numpad+) is working. btw i'm using notebook so it's not convenience so much to turn on numlock all the time

Comment 15

[Roman R.]

Yes, Karl, it was a reply to your comment.

The key between '.' and Shift is indeed '=' in the Russian layout; however, Shift and that key produce '%'. Yet, Ctrl and that key zooms up a page. Weird!

(In reply to comment #13)
> It might have been fortunate for you that the key you wanted to zoom up did
> just that, but we have to trust the keyboard layout to some extent.  IMO if the
> keyboard layout is set up to put + on a different key, then that seems like an
> indication that the author didn't want the usual key to produce a "+".

I think the author simply tried to fit as many Russian letters into Latin keyboard as possible (the difference is significant) and considered '+' not as important as others (also, it was always present on a desktop keyboard's number panel).

> What combination of keys normally enters a "+" character with this layout?
> What happens when Ctrl is added to that key combination?

As it's probably clear already -- none (without fn key).

Comment 16

[Karl Tomlinson (:karlt)]

(In reply to comment #15)
> Yes, Karl, it was a reply to your comment.
> 
> The key between '.' and Shift is indeed '=' in the Russian layout; however,
> Shift and that key produce '%'. Yet, Ctrl and that key zooms up a page. Weird!

Yes, weird.  That was so US keyboard users didn't need to use Shift...

> (In reply to comment #13)
> > What combination of keys normally enters a "+" character with this layout?
> 
> As it's probably clear already -- none (without fn key).

Thanks.

(In reply to comment #14)
> i can't use ctrl+= (zoom in), ctrl+- (zoom out) with thai (ketmanee) keyboard
> layout too.

If + is not available in the layout, I can understand why it would be nice to
have a key activate the shortcut based on its position in a Latin layout.

Looks like this may have used to work through detection of
VK_OEM_PLUS/VK_OEM_MINUS.  Some documentation seems to even recommend that
these be used in accel keys:

http://msdn2.microsoft.com/en-us/library/at7ah4df.aspx

but of course that causes problems:

http://blogs.msdn.com/michkap/archive/2006/04/02/567003.aspx

Maybe the real problem is the use of punctuation in accel keys (bug 88380),
but since these are commonly used shortcuts, maybe we could hack up something
for these cases.

Maybe it would be safe-ish to add a + or - like we do for Latin letters when
the virtual keycode is VK_OEM_PLUS or VK_OEM_MINUS and the actual characters
produced by the key are non-Latin/ASCII.

> * note that ctrl+(numpad+) is working. btw i'm using notebook so it's not
> convenience so much to turn on numlock all the time

Yes.  I wish my Think Pad would access numpad keys through Fn.

Comment 17

[Karl Tomlinson (:karlt)]

attachment 316802 [details] [diff] [review] may help with this

Comment 18

[Roman R.]

Karl, how can we test this? It's probably not available in any official build yet.

Comment 19

[Karl Tomlinson (:karlt)]

Please try this build here:

https://build.mozilla.org/tryserver-builds/2008-04-21_14:[e-mail]-zoom-3/

(It has attachment 316802 [details] [diff] [review] with the missing "}" added.)

Comment 20

[Roman R.]

I am happy with this test build. All shortcuts seem to be working. Thanks!

Comment 21

[Karl Tomlinson (:karlt)]

Thanks for testing!

Comment 22

[Damon Sicore (:damons)]

Wouldn't block the release, but would take a patch for 1.9.  Wanted1.9.0.x+.  Please request approval if appropriate.

Comment 23

[Tony Chung [:tchung]]

we need to add a keyboard navigation litmus suite for these kind of tests

Comment 24

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

fixed by bug 429510.